Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport Cover plaform from Core #751

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Backport Cover plaform from Core #751

merged 2 commits into from
Feb 8, 2022

Conversation

tetienne
Copy link
Collaborator

@tetienne tetienne commented Feb 4, 2022 •
edited
Loading

  • Add slow speed service

@github-actions github-actions bot added the enhancement New feature or request label Feb 4, 2022
@tetienne tetienne force-pushed the enhancement/backport-core-cover branch from 2cea1bb to 64da2b7 Compare February 8, 2022 09:28
@tetienne tetienne marked this pull request as ready for review February 8, 2022 09:36
@tetienne tetienne requested a review from iMicknl February 8, 2022 10:09
@tetienne tetienne enabled auto-merge (squash) February 8, 2022 10:09
iMicknl
iMicknl approved these changes Feb 8, 2022
View reviewed changes
Copy link
Owner

@iMicknl iMicknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1:1 core code, so LGTM. Would you want to get low position cover back in? Or not yet?

@tetienne tetienne merged commit def088c into master Feb 8, 2022
@tetienne tetienne deleted the enhancement/backport-core-cover branch February 8, 2022 10:12
@tetienne
Copy link
Collaborator Author

tetienne commented Feb 8, 2022

@iMicknl Sorry, I’ve enabled the auto merge. Yes, we should add back the low position service (but not the switch).

@iMicknl iMicknl added backport and removed enhancement New feature or request labels Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iMicknl iMicknl iMicknl approved these changes

@vlebourl vlebourl Awaiting requested review from vlebourl vlebourl is a code owner

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tetienne @iMicknl