-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mission Planner] new features development #1181
Comments
Awesome. All are great, but the safehomes setting would be very useful, even for people who don't fly missions. |
Fantastic!! All those updates will be awesome. Thanks Arno! |
Is it me or is there no button to save the waypoint altitude and speed anymore? Iirc there used to be a button for this, but now I can only save the changes by using the return key. Was this changed? |
Hi, yes, I've removed the save button to simplify the integration of Optional Non geo-point, as adding/removing/modifying the non geo-point table is automatically saved now. Thus a Save button would have done the action twice. Arno |
Okay, that makes sense, but can you also make the changes to the WP altitude and speed save automatically? It doesn't say anywhere that hitting return saves the WP, I only found out accidentally. There is also no feedback that it actually saved. This would be fine if it always saved immediately. |
Just had a play with the new Mission Control which is looking great. A few things I noted in the latest version were :
Still a work in progress so I'm sure most of the above are just pending finding the time. Just need to get absolute (true) altitude datums (iNavFlight/inav#6662) added into the mix and INAV missions will be highly configurable. Edit: forgot about support for previous versions of INAV which do allow multiple RTHs in a single mission. So scrub comment 1) above. |
Hi, Yes sure, I can change it in this way. I'll put it in my todo list in the next PR. Arno |
Hi @breadoven Thanks for the feedback. I'll take note about the points you mention. I try to have a look on it for the next PR. Arno |
hi @breadoven , On the third point you mention on Map not focusing, I'm not able to reproduce it. When I load a new file, the Map focuses automatically to the first WP. Can you provide me more information on your issue ? Arno |
You're right. Loading a mission file works OK. It's actually loading a mission from EEPROM that doesn't auto focus. |
Ok, I have found the issue for EPROM map focus. I have corrected it. I will push it with the other things (filename display, WP speed & Alt on the fly change, Distance computation with Jump). Arno |
Hi @breadoven , on the iNavFlight/inav#6662 topic, just to be sure, the P3 parameter to be set for indicating reference from Take-off level or Sea-level is only intended to be used for Non-Geo point, ie Waypoint, Land & PositionHold ? Arno |
Correct Arno, the absolute datum is just for geospatial WPs, so Waypoint, Land & PositionHold, i.e. those with an altitude setting. (I assume you meant geospatial rather than Non Geo ?). Is there any intention of pulling in ground elevation heights from the web to be shown for each WP ? Would be useful in the long run. |
Ok, thanks. Arno |
I've been using https://www.opentopodata.org/ Arno. Don't know if this is suitable for INAV or not. I'm sure there are better sources of DEM data. |
FYI, mwp is using Bing elevations for its inav 3.0 absolute <=> relative / landing altitude / terrain analysis / clearance features. Whilst it's a closed source, it provides excellent global coverage with the usage / performance issues that some of more open DEM provides have. In any case, to use the configurator's mission planning, Bing is pretty much a requirement anyway (same API key for tiles and elevations). |
@ArnoTlse I noticed that the |
Hi @breadoven, hi @stronnag, OK, thanks for the feedback. I have a quick look at both sources. Bing is already usable through the map Proxy features, so I guess using elevation from it should be done adapting the existing code for Bing api. I have not use already Bing, but it is the opportunity to do so. |
Hi @rts18, Thanks for the feedback. In the version I have in dev for the next PR coming soon (I try to finish the algorithm to compute mission distance taking into account Jump), this is already corrected. Arno |
The Google licensing is rather more problematic compared to the other sources. Bing is easy; simple JSON api, no real world usage restrictions. Beats me why there is not just a product key rather than forcing the user to get one; a number of open source tools have embedded Bing API keys, with, I would anticipate many more users that the Configurator. |
OK, I will look first at Bing solution as it is already in place for the tiles. I have also to figure out the resolution, to see if I can display a plot of the elevation under the mission path at a certain sampling and not only for each waypoint. Another question on a different topic, according to jump repeat : is a repeat equal to 0 is equivalent to have no jump in fact, or does it mean that the jump is done once only? |
In inav, as all altitudes are ultimately from the GPS, hence they are WGS84 ellipsoid.
Depends on location,but typically 30m, Bing allows you 1024 locations in a single request. mwp terrain analysis requests the lesser of 1024 and "distance_metres"/30, where "distance_metres" ignores jumps because its too confusing to view on an elevation plot (for me at least).
No jump. |
OK thanks. I wonder on the jump case for elevation, if you do not take them into account to avoid displaying similar branch several times, how do you plot the elevation on the jump branch to rally the jump target? This branch can be useful to display at least no? |
Just terminology I think; it's impossible for inav to know the local geoid MSL.
It would be useful, perhaps confusing and I'll have needed to do much more work in order to only display each jump once. Sure, possible, maybe one day, but for now a "ToDo". |
@ArnoTlse first of all, WOW man! You are doing an amazing job updating and upgrading the mission control!
Thanks for the hard work! :-) |
Hi, here is a first draw of the Elevation at WP level extracted from Bing Map API. I am now working on the Elevation profile + mission altitude profile plot underneath the Map. Elevation plot will be available by similar button as default settings. Dedicated icon will come. Arno |
Hi @Mateyhv , Thanks a lot for your feedback. It has been also possible thanks to the expertise and advises from Stronnag. Edit : Arno |
Thanks @ArnoTlse ! Much easier to understand whats going on :-) |
Hi, I have added a Home point to define Take Off location in order to get the WGS84 reference for Mission elevation. When WP altitude reference is set to WGS84 instead of Take Off location, the elevation of the WP is updated according to its reference. Some cleaning work remaining prior to a new PR soon. Arno |
Shouldn't this be the other way around Arno, i.e. if the WP altitude is relative to takeoff then the WP elevation is corrected to the WGS84 elevation (SL reference) based on the home elevation in order that it displays correctly in the elevation plot ? WPs that use the SL ref need to be set based on the desired absolute (true altitude in aviation speak) altitude only, the takeoff (home) elevation isn't relevant. It's only relevant to WP altitudes set relative to the takeoff. It's a bit tricky because you can only assume where the takeoff is likely to be but I suppose there's nothing you can do about that, just be aware that WPs set with a relative altitude will see that altitude vary in absolute terms if the takeoff position and therefore also the takeoff elevation changes. |
@ArnoTlse FYI, I recently added a planning assumed home to the optional / "private" |
Hi, I'm not sure If I have understood well your point.
What I have done here is :
Indeed, that's why I have had to add a Home (Take-off) location icon to let user assume where will be its Take-off location to ensure that height (when Take-off reference related) will not interfere with Earth elevation extracted from Bing Database. When the user moves the Home icon, it automatically updates the elevation plot and move the blue curve (for Take-off reference WP) accordingly. Arno |
Hi @stronnag , Ok thanks for the information. Arno |
That's correct. Great if we both use the same attribute tags. |
@ArnoTlse I noticed I cannot create waypoints when I don't have a flight controller connected. Is that WAI? |
No, works fine here. |
Nope, really does not work here. Step to reproduce:
This is with a fresh build of the |
Whatever, still works just fine here, without an FC in the room. |
Hi @stronnag , I have implemented the load and save home-x / home-y for home in a mission file. Will be in the next PR with Elevation. Arno |
Update of the on going list to add #1311 topics |
Don't know if you're still working on this Arno but thought I should mention I've got a working solution for Multi Missions (iNavFlight/inav#6765). Have you done anything related to this ? |
Hi, To be fair, I haven't progress so far on it. I have enjoyed the summer by flying and September and October were quite busy at work and at home. I plan to start reworking on this end of October. I will have a look deeper on what you have done. Arno |
Hi, Some updates here : #1311 (comment) Arno |
Hi,
I am currently planning working on those topics related to Mission planner tab in Inav Configurator :
DONE :
On-GOING :
batch 1 target Eo March 2022:
batch 2 target end of july 2022:
TO DO LIST :
I will update this issue each time a feature is developed.
Arno
The text was updated successfully, but these errors were encountered: