Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mission Planner] Elevation Profile & Home #1299

Merged
merged 7 commits into from
Aug 13, 2021

Conversation

ArnoTlse
Copy link
Contributor

@ArnoTlse ArnoTlse commented Jun 15, 2021

PR to add :

  • Elevation profile plot : display Earth elevation under mission + Mission elevation with regards to reference defined by user (relative to Take-off home or to MSL)
  • Home (Take-off location defined by user) icon + box to define an Home location
  • ability to switch Elevation reference from Take-Off to MSL + display into WP under edition the value of the Earth elevation beneath to help settings the altitude in MSL
  • add arrow to indicate sens for Jumps
  • Add number of WP in the WP edition Box

image

image

image

image

image

image

@breadoven
Copy link
Collaborator

@ArnoTlse. Awesome bit of work Arno, not sure why it hasn't been merged yet.

One thing that did occur to me though with the Sea Level Ref option as it is now is that it could be a bit dangerous to use if you didn't entirely understand what it does. This is because when SL Ref is selected ON it doesn't change the previously set WP altitude to account for the ground elevation which means the set altitude could be lower than ground elevation ... the craft will fly into the ground, e.g. if Alt is set to 50m and SL Ref is selected ON at a location with a ground elevation of 200m the WP will save with P3 set to 1 and an Alt setting of 50m ... which means the craft will try and fly to an altitude 150m below ground level.

I was thinking it would be better to set the altitude to the ground elevation + the previously set WP altitude when SL Ref is selected ON which ensures you will be clear of the ground, i.e. in the above example the Alt will change from 50m to 250m keeping you 50m above ground elevation. If selected OFF the ground elevation is subtracted from the altitude. I managed to make this change myself and it seems to work fine. What do you think ?

@DzikuVx DzikuVx added this to the 3.1 milestone Aug 13, 2021
@DzikuVx DzikuVx merged commit 32bd3fa into iNavFlight:master Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants