Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expanded labels for units #1551

Merged
merged 15 commits into from
Jun 26, 2022
Merged

Conversation

MrD-RC
Copy link
Collaborator

@MrD-RC MrD-RC commented Jun 10, 2022

This PR adds expanded hover labels for units.

image

@Jetrell
Copy link

Jetrell commented Jun 10, 2022

Pitch to Throttle ratio is explained as a ratio, therefor it has no unit... But it appears to be calculable in uS?

@MrD-RC
Copy link
Collaborator Author

MrD-RC commented Jun 11, 2022

@Jetrell Yes, you're right. It should be in uS. But you've now got me thinking is Ratio the correct term? It multiplies the pitch2thr value (which is throttle in uS) by the pitch angle. It's a multiplier rather than a ratio surely?

@Jetrell
Copy link

Jetrell commented Jun 11, 2022

I think it depends if its easier for a person to view it as an equation, or an interaction between variables.
In its simplest form. Its how many uS of throttle are changed per degree of Pitch offset from a level attitude.
But due to this value also being constrained by nav_fw_min_thr and nav_fw_max_thr ... I think a Ratio may encompass all of that better.
Does that seem right?

But, is it a Pitch to Throttle ratio (P2T) or a Throttle value changed, as a result of Pitch (T2P)?

Something I haven't tested. Is the P2T value constrained?
If someone was to entered a value like 50 (5% ). That would give a 50% throttle increase for 10 degrees of pitch... rather extreme.

We understand why its in uS.. for resolution. But I wonder if it would be easier for the average person to understand.. e.g. a value ratio of 5, being written as 0.5% throttle change to 1 degree of pitch change?

@DzikuVx DzikuVx added this to the 6.0 milestone Jun 21, 2022
@DzikuVx DzikuVx changed the base branch from release_5.0.0 to master June 21, 2022 06:29
@DzikuVx DzikuVx merged commit c61a56e into master Jun 26, 2022
@DzikuVx DzikuVx deleted the MrD_Add-expanded-labels-for-units branch June 26, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants