Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder blackbox fields #10068

Merged
merged 1 commit into from
May 23, 2024

Conversation

breadoven
Copy link
Collaborator

Moves blackbox activeWpNumber and rxUpdateRate fields to better position in BB Explorer field table.

@DzikuVx DzikuVx added this to the 8.0 milestone May 21, 2024
@breadoven breadoven merged commit 49008f4 into iNavFlight:master May 23, 2024
14 checks passed
@breadoven breadoven deleted the abo_blackbox_move_activewp branch May 23, 2024 10:19
@stronnag
Copy link
Collaborator

Out of interest, why is there no 23?

@breadoven
Copy link
Collaborator Author

breadoven commented May 23, 2024

Out of interest, why is there no 23?

Killswitch mode removed recently (#9856).

@stronnag
Copy link
Collaborator

Thanks. It (briefly) broke the blackbox-tools-inav code generator ....

@breadoven
Copy link
Collaborator Author

Ah, forgot about blackbox-tools-inav.

This stuff really needs fixing properly. It's confusing that it shows flightModeFlags in BB Explorer, which you would assume are the currently active flight modes, whereas in fact it's just showing the currently selected boxmodes which aren't necessarily "flight" modes as such or even active,

@stronnag
Copy link
Collaborator

Ah, forgot about blackbox-tools-inav.

This stuff really needs fixing properly. It's confusing that it shows flightModeFlags in BB Explorer, which you would assume are the currently active flight modes, whereas in fact it's just showing the currently selected boxmodes which aren't necessarily "flight" modes as such or even active,

It really needs to be done is a way that doesn't break every blackbox analysis tool in existence, e.g. as suggested previously by adding a new field for the bits > 31. That way extant tools still work and people who want bits > 31 can extract them from the new field.

@breadoven
Copy link
Collaborator Author

breadoven commented May 27, 2024

Ah, forgot about blackbox-tools-inav.
This stuff really needs fixing properly. It's confusing that it shows flightModeFlags in BB Explorer, which you would assume are the currently active flight modes, whereas in fact it's just showing the currently selected boxmodes which aren't necessarily "flight" modes as such or even active,

It really needs to be done is a way that doesn't break every blackbox analysis tool in existence, e.g. as suggested previously by adding a new field for the bits > 31. That way extant tools still work and people who want bits > 31 can extract them from the new field.

I'm thinking now that it might be easier to leave the boxId_e as is and instead just add another slowfield to blackbox for active flight modes based on the actual flightModeFlags bit mask since this is currently not recorded by the log. Logging additional box mode selections > 32 would then be a separate issue although the current blackbox "flightModeFlags" should be renamed to what it actually is ... boxModeFlags (unless this breaks things also ... haven't checked yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants