Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further serial gimbal/headtracker improvements #10159

Merged
merged 12 commits into from
Jun 22, 2024
Merged

Further serial gimbal/headtracker improvements #10159

merged 12 commits into from
Jun 22, 2024

Conversation

mmosca
Copy link
Collaborator

@mmosca mmosca commented Jun 21, 2024 •
edited
Loading

A follow up to #10109, for further improvement.

  • Add trim to gimbal to allow Uptilt on quad setups. This only applies to locked center mode.
set gimbal_pan_trim = 0
set gimbal_tilt_trim = 0
set gimbal_roll_trim = 0
  • Integrate with OSD pan compensation

@mmosca mmosca requested a review from MrD-RC June 21, 2024 15:39
@mmosca
Copy link
Collaborator Author

mmosca commented Jun 21, 2024

@MrD-RC can you check my changes to osd.c:osdGetPanServoOffset() ? This should get the pan compensation working, but I would like to double check if my logic for choosing servo input vs serial gimbal pan is sound.

@mmosca mmosca marked this pull request as ready for review June 21, 2024 15:41
@mmosca mmosca added this to the 8.0 milestone Jun 21, 2024
MrD-RC
MrD-RC reviewed Jun 21, 2024
View reviewed changes
src/main/io/osd.c Outdated Show resolved Hide resolved
mmosca added 3 commits June 22, 2024 10:43
@mmosca
Merge remote-tracking branch 'origin/master' into mmosca-gimbal-test
4c65077
@mmosca
Add pan trim to stick inputs and center checks
055642a 
Add pan trim to rc inputs so it can match center flight mode.

Also add pan trim to osd center checks.

I did not add pan trim to headtracker output, as that would probably
confuse the user more than not.

And not adding it to the headtracker input, the osd will still match the expected position.

You probably shouldn't be mounting your gimbal sideways, anyway. ;)
@mmosca
Fix center when no valid headtracker data is available
7ffb0bc
@mmosca mmosca merged commit 411186a into master Jun 22, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrD-RC MrD-RC MrD-RC left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mmosca @MrD-RC