Replace vbat_max_cell_voltage by the new vbat_cell_detect_voltage setting for detecting number of battery cells #3166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalentity
requested changes
May 5, 2018
src/main/sensors/battery.c
Outdated
| @@ -79,6 +79,7 @@ PG_RESET_TEMPLATE(batteryConfig_t, batteryConfig, | |||
|
|
|||
| .voltage = { | |||
| .scale = VBAT_SCALE_DEFAULT, | |||
| .cellDetect = 430, | |||
There was a problem hiding this comment.
Please remember to increase version when adding new parameters to PGs
PG_REGISTER_WITH_RESET_TEMPLATE(batteryConfig_t, batteryConfig, PG_BATTERY_CONFIG, 1);
There was a problem hiding this comment.
Indeed I forgot about the PG version. I think we could also set vbat_max_cell_voltage default to 4.20V now since it is not used for the cell count detection anymore and lower VBATT_CELL_FULL_MAX_DIFF default accordingly to 0.10V.
|
Also, MSP API and Configurator will have to be modified. |
shellixyz
force-pushed
the
add_vbat_cell_detect_voltage
branch
from
fabd9be to
4b286f6
Compare
…ting for detecting number of battery cells
shellixyz
force-pushed
the
add_vbat_cell_detect_voltage
branch
from
4b286f6 to
49b3444
Compare
|
Should be good for the firmware part |
digitalentity
approved these changes
May 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.