Add CLRACINGF4AIRV3 to CLRACINGF4AIR target #3239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bnn1044 is this ready? |
|
Yes. Test on the bench. |
|
@bnn1044 can you please rebase against development branch? |
|
@digitalentity Rebase done |
|
@bnn1044 there are numerous conflicts. Please fix. |
bnn1044
force-pushed
the
CLRACINGF4AIRV3
branch
2 times, most recently
from
1a865ff to
e14b7dd
Compare
fiam
reviewed
May 31, 2018
docs/Cli.md
Outdated
| @@ -341,6 +341,8 @@ Re-apply any new defaults as desired. | |||
| | yaw_deadband | 5 | These are values (in us) by how much RC input can be different before it's considered valid. For transmitters with jitter on outputs, this value can be increased. Defaults are zero, but can be increased up to 10 or so if rc inputs twitch while idle. | | |||
| | throttle_tilt_comp_str | 0 | Can be used in ANGLE and HORIZON mode and will automatically boost throttle when banking. Setting is in percentage, 0=disabled. | | |||
| | flaperon_throw_offset | 200 | Defines throw range in us for both ailerons that will be passed to servo mixer via input source 14 (`FEATURE FLAPS`) when FLAPERON mode is activated. | | |||
| | gimbal_mode | NORMAL | When feature SERVO_TILT is enabled, this can be either NORMAL or MIXTILT | | |||
| >>>>>>> fc9ab94... add CLRACINGF4AIRV3 TARGET | |||
There was a problem hiding this comment.
There are conflict markers merged. Also, it looks like this touches a lot of places that it shouldn't.
There was a problem hiding this comment.
Hmm. Look like the rebase to development I messed up. Will update later. Thanks.
digitalentity
previously requested changes
Jun 15, 2018
| @@ -0,0 +1,929 @@ | |||
| /** | |||
| @@ -0,0 +1,332 @@ | |||
| /* | |||
There was a problem hiding this comment.
Same applies for this file - it doesn't belog here
There was a problem hiding this comment.
OK. I use the development as base.
I don't know why it is there.
|
This seems fixed now. |
fiam
dismissed
digitalentity’s stale review
Problems pointed in this review are now fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add CLRACINGF4AIR V3 target.