Separate OSD layout responses over MSP by layout #3420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since sending the whole layouts over MSP was making the layouts response too big (bigger than the default 512 bytes MSP TX buffer), each OSD layout is now sent separately via by making MSP2_INAV_OSD_LAYOUTS an in/out message. Also, all 5 in/out messages have now been moved to a function which handles all of them (mspFCProcessInOutCommand()). Fixes crash when retriving the OSD layouts via MSP.
fiam
force-pushed
the
agh_msp_osd_separate_layouts
branch
from
c018f03
to
414cd2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since sending the whole layouts over MSP was making the layouts
response too big (bigger than the default 512 bytes MSP TX buffer),
each OSD layout is now sent separately via by making
MSP2_INAV_OSD_LAYOUTS an in/out message.
Also, all 5 in/out messages have now been moved to a function which
handles all of them (mspFCProcessInOutCommand()).
Fixes crash when retriving the OSD layouts via MSP.
Configurator PR iNavFlight/inav-configurator#486