Fix broken tests, require them to pass in Travis checks #3504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alignSensors() was renamed to applySensorAlignment() and now takes 3 arguments.
- fp_vector is now fpVector3_t - Vector rotation is now done via matrix rather than using rotateV
gyroUpdate(void) changed gyroUpdate(timeDelta_t) Also, gyro_sync driver no longer exists
openSerial() and getAmperage() needed prototype changes
Unit test now compiles, but unfortunately it seems that the tests are incorrectly mocking the device responses and a new driver is on the way, so there's no reason to fix this test for now.
The Makefile was returning success via || true even if the tests failed to run.
Header was accidentally included by cms/cms.h
This makes it return true when the channels have been updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.