Pitot sensor fixes and improvements #3977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
digitalentity
commented
Nov 1, 2018
digitalentity
commented
- Refactor pitot tube sensor
- Change filtering and defaults
- Change I2C driver code to handle 0xFF register address
- Better MS4525 sensor driver
- Validate default calibration for MS4525 and ADC sensors
digitalentity
force-pushed
the
de_pitot_fixes
branch
from
f5ec6bd
to
7d80d4e
Compare
junwoo091400
reviewed
Dec 5, 2018
| float dP = (10 * (int32_t)(dp_raw)) * 0.1052120688f; | ||
| float T = (float)(200 * (int32_t)dT_raw - 102350) / 2047 + 273.15f; | ||
| //float dP = ctx->ms4525_up * 10.0f * 0.1052120688f; | ||
| const float dP_psi = -((ctx->ms4525_up - 0.1f * 16383) * (P_max - P_min) / (0.8f * 16383) + P_min); |
There was a problem hiding this comment.
Is the Negative Sign('-') Intentional? Seems redundant anyway, but I wondered if that had any physical meaning :/
… driver code to handle 0xFF register address; Better MS4525 sensor
digitalentity
force-pushed
the
de_pitot_fixes
branch
from
4558d62
to
30463dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.