Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mag gain computation for negative mag zero #6636

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

DzikuVx
Copy link
Member

@DzikuVx DzikuVx commented Feb 24, 2021

Closes #6518

@ZlatanZ please review

@DzikuVx DzikuVx added the Release Notes Add this when a PR needs to be mentioned in the release notes label Feb 24, 2021
@DzikuVx DzikuVx added this to the 2.6.1 milestone Feb 24, 2021
@avsaase
Copy link
Member

avsaase commented Feb 24, 2021

I just did a quick WP mission on a small field near my house. It was a very slow mission with only 1m/s speeds, and I didn't do any acro, but the compass seems to work fine. The calibration in the configurator also didn't show any problems. Here is the log in case you want to look at anything specific: blackbox_log_2021-02-24_151606.TXT.

@DzikuVx DzikuVx merged commit ba3d0ab into master Feb 24, 2021
@DzikuVx DzikuVx deleted the dzikuvx-fix-mag-gain-calibration branch February 24, 2021 16:54
DzikuVx added a commit that referenced this pull request Feb 24, 2021
…tion

Fix mag gain computation for negative mag zero
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Notes Add this when a PR needs to be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compass calibration calculates wrong gain values
2 participants