Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copter: add new setting for final landing vspeed instead of being hardcoded to 25% of set landing vspeed #6853

Conversation

shellixyz
Copy link
Collaborator

@shellixyz shellixyz commented Apr 19, 2021

Tested, seems to work fine

Configurator part: iNavFlight/inav-configurator#1235

Testing video:

Settings:
set nav_landing_minalt_vspd = 50
set nav_landing_maxalt_vspd = 300
set nav_land_slowdown_minalt = 200
set nav_land_slowdown_maxalt = 1000

https://youtu.be/3pynEufaYqE

@shellixyz shellixyz added Ready to merge Release Notes Add this when a PR needs to be mentioned in the release notes labels Apr 19, 2021
@shellixyz shellixyz added this to the 3.0 milestone Apr 19, 2021
@stronnag
Copy link
Collaborator

@shellixyz Michel,there's a couple of places in settings.yaml where the 25% is mentioned explicitly in the description: nav_land_slowdown_minalt, nav_land_slowdown_maxalt. The description should be amended to reference the nav_landing_minalt_vspd setting instead of hard-coded 25%.

@shellixyz
Copy link
Collaborator Author

@shellixyz Michel,there's a couple of places in settings.yaml where the 25% is mentioned explicitly in the description: nav_land_slowdown_minalt, nav_land_slowdown_maxalt. The description should be amended to reference the nav_landing_minalt_vspd setting instead of hard-coded 25%.

Thank you @stronnag, should be good now

@shellixyz shellixyz force-pushed the improvement/copter_landing_new_setting_for_minalt_speed branch from 2df99fd to b668c47 Compare April 19, 2021 18:11
@shellixyz shellixyz force-pushed the improvement/copter_landing_new_setting_for_minalt_speed branch from b668c47 to 5988f45 Compare April 19, 2021 18:51
@shellixyz shellixyz merged commit a008a81 into iNavFlight:master Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge Release Notes Add this when a PR needs to be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants