New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix array overflow with 11S-14S battery in Mavlink #7478

Merged

stronnag merged 1 commit into master from prevent_11S-14S_overflow_mavlink

Sep 26, 2021

Collaborator

stronnag commented Sep 25, 2021

Smashing the stack considered harmful, so let's avoid it.

/home/jrh/Projects/fc/inav/src/main/telemetry/mavlink.c:780:39: error: array subscript 10 is above array bounds of 'uint16_t[4]' {aka 'short unsigned int[4]'} [-Werror=array-bounds]
  780 |                     batteryVoltagesExt[cell] = getBatteryAverageCellVoltage() * 10;
      |                     ~~~~~~~~~~~~~~~~~~^~~~~~

For all those power fiends on 11S - 14S batteries.


          fix array overflow with 11S-14S battery in Mavlink

4accafb

stronnag added this to the 4.0 milestone

stronnag merged commit df1e013 into master

stronnag deleted the prevent_11S-14S_overflow_mavlink branch

September 26, 2021 10:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet