-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gyro.c] An option to not calibrate the gyro during boot #7624
[gyro.c] An option to not calibrate the gyro during boot #7624
Conversation
The extension "fc/config.h" is included but still returns an error. VSCode compiles normal, no errors |
build fails because of "sensor_gyro_unittest.cc" |
Is there any benefit to this? It usually takes longer to get a GPS fix than wait for the gyro to calibrate. So I don’t really see it being useful for fixed wing. However, it could be good for people with drones who want to fly from boats for some crazy reason. There was an issue raised a few months ago that their quad’s gyro wouldn’t calibrate on a boat 😆 |
no benefit... other than being able to use the Quad on a boat 😆 |
There is a benefit and I'm very happy this is done. The benefit is: with no gyro runtime calibration you can arm on the boat :) Believe me, we had such requests |
Fixed unit test compilation error! |
this also causes the INS 1G gravity calibration to be ignored, when |
this implementation was tested on a Matek F405-SE, and everything worked fine... I believe I won't be doing any more Pushes for this PR. |
@JulioCesarMatias if you could fix settings that would be awesome :) |
all new PR are giving the same problem in "settings.md" |
I'm a bit on the fence regarding this feature. TDK gyros are known for have significant gyro bias which is also subject to be temperature/mechanical stress/time dependent. This feature may create weird to troubleshoot issues, but it could be improved by creating an offline gyro calibration proceadure and a set of |
@digitalentity For 2 or 3 times I was already building a special version of INAV for people that wanted to arm their quads or airplanes on boats. So there is practical use for such a solution. @JulioCesarMatias try merging |
…bration [gyro.c] An option to not calibrate the gyro during boot (cherry picked from commit 4b38672)
Thank you for working on this, Just wanted to add some context here for any devs reading in the future who might want to extend or modify this feature. I did a search and didn't see any discussions on arming on boats or being stuck on calibrating but i can see that it obviously has been discussed and considered so thank you!! Context: Troubleshooting Obviously out testing the day before on land and previous success launching 5" from the boats meant this caught us off guard on the day with a lot of crew and talent and people waiting. our work around was to move the barge into calmer water, arm on the shore and go back on the boat to launch etc. So again thanks to the team for working on this. Safety First Suggestions and potential improvements: Before we launch we want to know the quad will behave as expected which is why the checks are there to begin with and I appreciate that. Can you think a way to visually test this pre-arm via the OSD or using a buzzer. perhaps a 45" alarm
If there is another way to do the same thing on DJI FPV system using OSD etc let me know! Anything that can give the pilot confidence the sensors are performing visually or audibly if we are to use "Last known Good Gyro" Just an IDEA, even when we got it to arm there was a sense of anxiety doing the hover test etc, was it a gyro issue or a startup warning issue was not clear to us and when its $20K of equipment on the line anything that adds safety without complexity is welcomed. With smaller 5" we have ways to do it POST arm, with a bigger quad its not a safe thing to do physically. Cheers! Rob |
I see this as a good alternative for those who use iNav with an airplane and don't want to wait for the gyro calibration to finish.
CLI:
init_gyro_cal
: If defined toOFF
, it will ignore the gyroscope calibration done at each startup. Instead, the gyroscope last calibration from when you calibrated will be used. It also means you don't have to keep the UAV stationary during a startup.gyro_zero_x
: gyro X calibration storedgyro_zero_y
: gyro Y calibration storedgyro_zero_z
: gyro Z calibration stored