Add switch position indicators to the OSD #7734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changed to allow up to 4 characters for the name. |
|
This update makes this feature much more customisable. The name can be up to 4 characters, and the text can also be aligned to the left or right of the switch. The configurator updates to show the correct visuals to how it will be drawn on the actual OSD. |
|
Future enhancement. Activate via LC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds four switch position indicators to the OSD. Fixes #7717
Requires configurator change iNavFlight/inav-configurator#1429
Each switch position indicator can be enabled or disabled like any other OSD element. They are also configurable on the right of the screen. This allows the pilot to assign a letter to the switch indicator, and the channel that it watches.
This is a demo of the PR working
As a side effect, strings are now handled by the MSPHelper for the data-setting method of communication. Before they would just throw an exception.