Add target SKYSTARSF722MINIHD #8794
Conversation
| #define TARGET_BOARD_IDENTIFIER "SS7D" | ||
|
|
||
| #ifdef SKYSTARSF7MINIHD | ||
| #define TARGET_BOARD_IDENTIFIER "SSF7MHD" |
There was a problem hiding this comment.
Isn't TARGET_BOARD_IDENTIFIER supposed to be 4 characters only?
There was a problem hiding this comment.
I don't think it is a problem. Some target board identifiers are longer. I think the longest one is the one for the iFlight Blitz F7 Pro which is 12 chars long
There was a problem hiding this comment.
Perhaps we can use SS7D for one and SS7H for the other, to avoid issues with the TARGET_BOARD_IDENTIFIER.
Looking over the fence, on the BF side, it is just an identifier for the mcu used (makes sense for unified targets).
We can probably drop the uniquines requirement in INAV and change it to either be a 4 byte manufacturer id, or platform type like bf.
The TARGET_BOARD_IDENTIFIER is used in msp messages (limited to 4 bytes) and in crsf telemetry's device info. The crsf device info is just a string and could use USBD_PRODUCT_STRING instead.
|
Noting that MSP_BOARD_INFO only sends four bytes, so if a consumer were to depend on unique IDs then longer IDs not unique in the first four characters may cause ambiguity. |
|
It looks like this wouldn't be the first target to exceed the recommend size for TARGET_BOARD_IDENTIFIER, so it should at least not be a blocker for merging. Since this missed the 6.0 train, should we target it to 6.1? Fyi: these all have board identifiers that are too long: TMOTORF7V2, IFLIGHT_BLITZ_F7_PRO, RUSH_BLADE_F7, KROOZX, AXISFLYINGF7PRO, YUPIF4, IFLIGHT_JBF7PRO, TMOTORF7V2, IFLIGHT_BLITZ_F722, TMOTORF7. |
|
@shellixyz can you target release_6.1.0? There will probably be a 6.1.0 release candidate soon. |
shellixyz
force-pushed
the
target/SKYSTARSF722MINIHD
branch
from
87282ac
to
efeb35c
Compare
shellixyz
force-pushed
the
target/SKYSTARSF722MINIHD
branch
2 times, most recently
from
fc1ca01
to
5ca30e9
Compare
|
Done. I also changed the TARGET_BOARD_IDENTIFIER to be only 4 chars |
|
Aren’t you supposed to be having a break 🤣 |
No description provided.