Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to BFCOMPAT character and icon mappings #8926

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

rmaia3d
Copy link
Contributor

@rmaia3d rmaia3d commented Mar 30, 2023

Improve the character and icon mappings for BF compatible OSD modes, both BF43COMPAT and the upcoming BFHDCOMPAT mode.

This should reduce the number of "?" characters, by using more of the available icons provided by DJI or direct letter abbreviations.

Reference for the available characters:

206867459-f80aa2b9-11f2-46b4-bbd7-8a33cc29142c

@DzikuVx DzikuVx added this to the 6.1 milestone Mar 30, 2023
@DzikuVx
Copy link
Member

DzikuVx commented Mar 30, 2023

Awesome. Thank you

@DzikuVx DzikuVx merged commit 0e4eead into iNavFlight:release_6.1.0 Mar 30, 2023

// GPS and navigation
#define BF_SYM_LAT 0x89
#define BF_SYM_LON 0x98
#define BF_SYM_ALTITUDE 0x7F
#define BF_SYM_TOTAL_DISTANCE 0x71
#define BF_SYM_TOTAL_DISTANCE 0x2A
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bug in DJI's font. I don't think we should change this.

In theory they are working with the BF team and may fix this.
I don't think we should deviate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested and they are working on my goggles. If DJI changes it, we change it as well, I don't see a problem here.

@@ -32,12 +32,14 @@
#define BF_SYM_ROLL 0x14
#define BF_SYM_PITCH 0x15
#define BF_SYM_TEMPERATURE 0x7A
#define BF_SYM_MAX 0x24
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These symbols don't exist in betaflight, so we should not add them here.

This file is based on betaflight/src/main/drivers/osd_symbols.h

Also, refer to https://betaflight.com/docs/development/osd

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not? These symbols work just fine for me, so what's the point of trying to exactly mirror Betaflight's behavior, can't we improve on it?

@druckgott
Copy link
Contributor

druckgott commented Sep 11, 2023

Is there some discussion ongoing. I have some topics which have questionmark which is not realy nice:
grafik
grafik

Would be realy nice if there comes a solution. From my point of view it´s better to have a Letter there then to have a ?.
In my intention it´s also ok to copy it exacly like in betaflight, if there is a comparing value.

Maybe the User can replace the ? byitself in any way that would also be a good solution. The current solution with the ? is in my point of view the badest one ;-).

@mmosca
Copy link
Collaborator

mmosca commented Sep 11, 2023

Is there some discussion ongoing. I have some topics which have questionmark which is not realy nice: grafik grafik

Would be realy nice if there comes a solution. From my point of view it´s better to have a Letter there then to have a ?. In my intention it´s also ok to copy it exacly like in betaflight, if there is a comparing value.

Maybe the User can replace the ? byitself in any way that would also be a good solution. The current solution with the ? is in my point of view the badest one ;-).

Only DJI can provide a proper fix. They need to support fonts for other flight controllers. Betaflight does not have a symbol for what is show as a question mark.

@MrD-RC
Copy link
Collaborator

MrD-RC commented Sep 11, 2023

IMHO, we have messed about with the OSD code enough already for DJI. There is a lot of mess in there now because DJI doesn’t want to implement MSP DisplayPort properly and fully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants