Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with DJI O3 showing miles instead of kFt #9007

Merged

Conversation

MrD-RC
Copy link
Collaborator

@MrD-RC MrD-RC commented Apr 24, 2023

Fixes #9005

Tested on other systems via HITL. All fine. Should be tested by someone with the O3 system for final confirmation.

Fixes #9005

Tested on other systems via HITL. All fine. Should be tested by someone with the O3 system for final confirmation.
@MrD-RC MrD-RC added this to the 6.1 milestone Apr 24, 2023
@MrD-RC MrD-RC requested review from DzikuVx and mmosca April 24, 2023 19:24
@prelator
Copy link

Looks like this corrects it to give altitude in thousands of feet. While better, would it be possible to just always give altitude in feet without decimals, like INAV 6.0 does?

@MrD-RC
Copy link
Collaborator Author

MrD-RC commented Apr 24, 2023

Looks like this corrects it to give altitude in thousands of feet. While better, would it be possible to just always give altitude in feet without decimals, like INAV 6.0 does?

INAV 6 doesn't do that. Altitude has always been kFt. If 6.0 showed something different, it was because of this bug. The altitude has space only for 3 digits. Which is why kFt is used.

@mmosca
Copy link
Collaborator

mmosca commented Apr 24, 2023

@MrD-RC I will try to test this later this week, but it is possible to verify BF*COMPAT behavior with Walksnail in case you ever want to verify behavior with your hardware.

Just pick BFHDCOMPAT as OSD type and manually set the FC type to Betaflight in the goggles menu. This will tell the goggles to use the BF font, which is exactly what DJI does.

@MrD-RC
Copy link
Collaborator Author

MrD-RC commented Apr 24, 2023

@MrD-RC I will try to test this later this week, but it is possible to verify BF*COMPAT behavior with Walksnail in case you ever want to verify behavior with your hardware.

Just pick BFHDCOMPAT as OSD type and manually set the FC type to Betaflight in the goggles menu. This will tell the goggles to use the BF font, which is exactly what DJI does.

I don't really want to infect the Walksnail stuff with anything DJI. They may stop working in disgust 😉

Great tip though 👍🏻

@mmosca
Copy link
Collaborator

mmosca commented Apr 24, 2023

I can confirm it will show 1.XX above 1000ft. Tested on o3 + v2 w/hitl

@MrD-RC
Copy link
Collaborator Author

MrD-RC commented Apr 25, 2023

Thanks @mmosca

ready to merge in that case.

@MrD-RC MrD-RC merged commit 7019b60 into release_6.1.0 Apr 25, 2023
@MrD-RC MrD-RC deleted the MrD_Yet-another-fix-due-to-DJIs-fucking-incompetence branch April 25, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants