Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aligned KAKUTEH7WING target with manufacturer docs #9640

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

paulwrath1223
Copy link
Contributor

Super simple fix for this issue.

!! This risks breaking older builds that attached sensors to the FC in accordance with the iNav target and not the manufacturer docs !!

The Kakute H743 Wing target in iNav lists the Pitot sensor as being on I2C bus 1, but HolyBro says to use I2C bus 2.

Manufacturer Manual says I2C bus 1 is just for compass, and other peripherals should use I2C bus 2.

Also the wiring diagram uses I2C bus 2:
image

This PR just changed the pitot, rangefinder, and external temp sensors to I2C bus 2

@sensei-hacker
Copy link
Collaborator

Paul, I believe you said you tested this with a pitot in the external i2c plug, labeled i2c 2. Correct?

Note - the key line in the manual is probably:
3x I2C (I2C1 and I2C2 for external devices , I2C4 for onboard sensors )

@vincentpoont2
Copy link
Contributor

@DzikuVx Our I2C1 is designed to be use with our GPS+Compass, so I think it make sense to make this change.

@mmosca
Copy link
Collaborator

mmosca commented Jan 16, 2024

Can we add a remark to what sensors go in which i2c bus/plug to docs/boards/KAKUTEH7WING.md ?

@paulwrath1223
Copy link
Contributor Author

paulwrath1223 commented Jan 16, 2024

Can we add a remark to what sensors go in which i2c bus/plug to docs/boards/KAKUTEH7WING.md ?

There currently isn't a doc file for this board. I don't mind making one, now that I have the board and know the system better than I wanted to, but should I put it in a separate PR?

NVM, Thanks @sensei-hacker

@paulwrath1223
Copy link
Contributor Author

Paul, I believe you said you tested this with a pitot in the external i2c plug, labeled i2c 2. Correct?

Note - the key line in the manual is probably: 3x I2C (I2C1 and I2C2 for external devices , I2C4 for onboard sensors )

Yes. I flashed the firmware with this change and confirmed it works as I would expect. (With I2C 1 only working for the included mag and the unused plug for other peripherals) I only have a pitot and mag, so I was unable to test the external temperature and rangefinder changes, but I can't imagine they will behave any differently.

Documents i2c usage on KAKUTEH7WING
@sensei-hacker sensei-hacker merged commit 1d12c7f into iNavFlight:master Jan 16, 2024
14 checks passed
@DzikuVx DzikuVx added this to the 8.0 milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants