-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FW Nav Auto Landing fixes #9940
FW Nav Auto Landing fixes #9940
Conversation
Awesome, will test the fixes tomorrow. Thanks a lot. |
Ran some quick tests this afternoon.. It now appears to shut off the motor and disarm after a mission Has anyone else noticed their planes will sometimes linger at @b14ckyy |
@Jetrell I had that once when my Loiter radius was accidently set to 50cm instead of 50m. It took sometimes a few minutes until the plane actually considered the loiter to be entered to switch into wind check or start descent. After the loiter radius was not too small anymore I never had a problem again. I was not able to test yesterday. Started to rain all afternoon. |
It fails to detect you've arrived at the RTH home point because it simply looks to see if you're within 1.1 * I think there's perhaps a better way of doing this which just looks to see if the plane has started to loiter around the home/hold point. This might mean it arrives too early but since this would only affect RTH which ends up in some kind of loiter at the home point regardless it shouldn't make any difference. I'll test and see. |
@breadoven please resolve conflicts. And shall we merge or wait? |
when solved and it fixes the disarm issue, imho its ready to merge. Optimizations and enhancements can be done in the future. The disarm bug is more important to be fixed. |
I tested this in HITL pretty thoroughly and it worked as expected so I don't see why it shouldn't work in real flight just the same given it's just logic changes which HITL should simulate exactly. Should be good to merge on that basis and also the testing by @Jetrell. |
Closes #9916. Also fixes 2 other issues:
NAV_STATE_FW_LANDING_FINISHED
.WP RTH Landing state code also cleaned up.
Tests OK in HITL.