Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Nav hold changes #9999

Merged
merged 1 commit into from
May 2, 2024

Conversation

breadoven
Copy link
Collaborator

@breadoven breadoven commented May 1, 2024

Removes one of the changes in #9947 which causes problems during fixed wing WP mode, Loiter at the last WP becomes unreliable. Also fixes the possibility of the same issue affecting WP Hold waypoints. Probably more likely to occur if the loiter radius is set too small.

@breadoven breadoven added this to the 7.1.1 milestone May 1, 2024
@DzikuVx DzikuVx merged commit f88f630 into iNavFlight:release_7.1.1 May 2, 2024
14 checks passed
@breadoven
Copy link
Collaborator Author

Hmmm, reverting the previous change didn't entirely fix this problem, according to HITL testing at least. Seems it occurs if you arrive at the final WP fast, e.g. following a steep dive from the previous WP, and have the loiter radius set too small. The plane can't turn tight enough at the final WP to stay within the distance required to keep the loiter turn active at which point it becomes unpredictable. Sometimes it turns back and recovers the loiter but a few times it flew off for a while before a forced turn was triggered (heading error > 170) and it flew back then loitered normally.

Can't remember seeing it do this before with the same loiter radius set, but it could just be that HITL had some wind active which was enough to make a difference. Need to do some more testing.

@breadoven breadoven deleted the abo_nav_hold_fix branch May 3, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants