feat: Terraform GitHub Actions #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as ready for review
mdobosz-isp
reviewed
Aug 27, 2020
terraform-actions/fmt.sh
Outdated
| echo | ||
| fi | ||
|
|
||
| if [ "$GITHUB_EVENT_NAME" == "pull_request" ] && ([ "${commentStatus}" == "Failed" ]); then |
There was a problem hiding this comment.
Suggested change
| if [ "$GITHUB_EVENT_NAME" == "pull_request" ] && ([ "${commentStatus}" == "Failed" ]); then | |
| if [ "$GITHUB_EVENT_NAME" == "pull_request" ] && [ "${commentStatus}" == "Failed" ]; then |
mdobosz-isp
reviewed
Aug 27, 2020
terraform-actions/helmfile.yaml
Outdated
| @@ -0,0 +1,7 @@ | |||
| repositories: | |||
There was a problem hiding this comment.
And by this I mean the file.
There was a problem hiding this comment.
Nope, this is what I get with a lazy git add -A
mdobosz-isp
reviewed
Aug 27, 2020
terraform-actions/init.sh
Outdated
Comment on lines
15
to
19
| if [ ${exitCode} -ne 0 ]; then | ||
| echo "Error: Failed to run terraform init" | ||
| echo "${output}" | ||
| echo | ||
| fi |
There was a problem hiding this comment.
Suggested change
| if [ ${exitCode} -ne 0 ]; then | |
| echo "Error: Failed to run terraform init" | |
| echo "${output}" | |
| echo | |
| fi | |
| echo "Error: Failed to run terraform init" | |
| echo "${output}" | |
| echo |
mdobosz-isp
approved these changes
Aug 27, 2020
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified these on another repo. Everything works as previously discussed. These are composite actions so they run quickly. They expect that
terraformis already installed (which we'd do in previous steps viaasdf). Each sub command will be its own step which ultimately will write its own PR comment.