Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to download/update libraries without starting mirai #8

Merged
merged 5 commits into from
Oct 30, 2020

Conversation

dousha
Copy link
Contributor

@dousha dousha commented Oct 30, 2020

This feature is intended for creating distributing packages such as building a docker image with a specific set of libraries without the need of downloading them on the first run (since end users might expect a smooth out-of-box experience).

@PeratX
Copy link
Member

PeratX commented Oct 30, 2020

个人认为,判断z这个参数的位置可以修改

@dousha
Copy link
Contributor Author

dousha commented Oct 30, 2020

一般来说是考虑有 -z 的情况下可以不进入 boot 阶段,但这样似乎难以通过仅修改脚本实现。

boot 阶段一开始就判断 -z 并决定要不要跳出更容易实现一些,即现在的写法。

如果有更好的方案,不妨给个提示?

@PeratX
Copy link
Member

PeratX commented Oct 30, 2020

可以考虑添加到ScriptManager中实现,这样可以直接跳过boot阶段

@PeratX
Copy link
Member

PeratX commented Oct 30, 2020

其实现在这样也是可以的

@PeratX PeratX merged commit ec7e0e3 into iTXTech:master Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants