Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to threejs r152 #2123

Closed
wants to merge 1 commit into from
Closed

Update to threejs r152 #2123

wants to merge 1 commit into from

Conversation

ketourneau
Copy link
Contributor

Description

We try to use iTowns in our project with another viewer which use threejs r152.

So we need to update iTowns to threejs r152 to use it.

@jailln
Copy link
Contributor

jailln commented Jun 29, 2023

Hi, thanks for this contribution :)
It's actually already ongoing in #1977 (where we update all itowns dependencies) and it should be merged pretty soon. I'll leave it open for now in case #1977 takes too long and we want to merge this first.

@gchoqueux
Copy link
Contributor

hello
you could just pick this PR commit 30edef65961fb61f8ecab216ee2125e9eeb892ec
and @mgermerie will remove this commit from his PR

@jailln
Copy link
Contributor

jailln commented Jun 29, 2023

hello you could just pick this PR commit 30edef65961fb61f8ecab216ee2125e9eeb892ec and @mgermerie will remove this commit from his PR

Yes, and this one too: 738f5ae

@ketourneau ketourneau closed this Jul 3, 2023
@ketourneau ketourneau deleted the three-152 branch July 3, 2023 12:06
@ketourneau ketourneau mentioned this pull request Jul 3, 2023
Merged
@ketourneau
Copy link
Contributor Author

I created new MR with correct version name : #2127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ketourneau @jailln @gchoqueux