Skip to content
This repository has been archived by the owner on May 31, 2023. It is now read-only.

Add Role management #72

Merged
merged 2 commits into from
Sep 7, 2021
Merged

Add Role management #72

merged 2 commits into from
Sep 7, 2021

Conversation

raplemie
Copy link
Collaborator

@raplemie raplemie commented Sep 3, 2021

Role management

Added role create/update/delete with limited set of permissions, if a role contains permissions not in the list managed by the demo portal, the whole role is locked and cant be edited. (Preventing unexpected removal of permission and be unable to set it back)
RoleManagement

Added role editing for users, directly in the users table:

UserRoleManagement

Other notable changes

Role operations

Created the role operations similar to project operations so we can eventually move to admin-component-react if needed.

Tests

Added msw package to mock network instead of fetch request, while this caused me issue setting up, I think this is a good way of testing.

@raplemie raplemie self-assigned this Sep 3, 2021
@raplemie raplemie temporarily deployed to CI September 3, 2021 20:44 Inactive
@raplemie raplemie temporarily deployed to CI September 3, 2021 21:52 Inactive
@raplemie
Copy link
Collaborator Author

raplemie commented Sep 3, 2021

Fixed loading on edit, scrolling on huge permissions list, and warning positionning so update/cancel are visible:
ScrollLoadingWarning

Copy link
Collaborator

@kckst8 kckst8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor comment

@raplemie raplemie merged commit 81451fa into master Sep 7, 2021
@raplemie raplemie deleted the raplemie/roleManagement branch September 7, 2021 15:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants