Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression 4.9.2 where aliased ECClassId switch from returning classId to className (backport #891) [release/4.9.x] #894

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Oct 21, 2024

  1. CTE query returning classid switch from className to classId in 4.9.x. This broke a user.
  2. PR 7235 Fix CTE, but this requires properly handling extendType information. This result in another break in behavior where aliased classid property was return as className. In 4.8.x/ 4.9.0 it used to return Id not class name. This break only happens for Concurrent Query for ECSqlStatement was fine as it set a flag called DoNotConvertClassIdsToClassNamesWhenAliased to reproduce previous behavior.
  3. This PR also set DoNotConvertClassIdsToClassNamesWhenAliased for concurrent query to reproduce behavior of classId returning class name when aliased to be compilable with 4.8.x

First query that broke user is following

SELECT t(aClassId) AS (SELECT ECClassId FROM Bis.Element) SELECT * FROM t
-- 4.8.x return className
-- 4.9.0 return classId
SELECT ECClassId AS aClassId FROM Bis.Element
--4.9.0 returned classId
--4.9.2 return className

After current fix

SELECT t(aClassId) AS (SELECT ECClassId FROM Bis.Element) SELECT * FROM t
-- return className as in 4.8.x
SELECT ECClassId AS aClassId FROM Bis.Element
-- returned classId  as in 4.8.x

itwinjs-core: iTwin/itwinjs-core#7282


This is an automatic backport of pull request #891 done by [Mergify](https://mergify.com).

…ry to keep compliance with 4.8.x row format (#891)

(cherry picked from commit b3a7aab)
@khanaffan
Copy link
Contributor

/azp run imodel-native

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DanRod1999
Copy link
Contributor

/azp run imodel-native

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DanRod1999
Copy link
Contributor

linked PR was not on its own line in the PR description, so the regex didn't pick it up. I corrected it, and should be running fine now.

@khanaffan khanaffan merged commit 1d711e5 into release/4.9.x Oct 21, 2024
17 checks passed
@khanaffan khanaffan deleted the mergify/bp/release/4.9.x/pr-891 branch October 21, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants