Convert getModelProps RPC operation to a GET request from POST (#3835)

* change getModelProps to a GET request * rush change
iTwin · Jun 20, 2022 · 5aee808 · 5aee808
1 parent 6a8d16c
commit 5aee808
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/common/changes/@itwin/core-common/nick-cache-getModelProps_2022-06-20-13-16.json b/common/changes/@itwin/core-common/nick-cache-getModelProps_2022-06-20-13-16.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@itwin/core-common",
+      "comment": "make getModelProps a GET request instead of a POST",
+      "type": "none"
+    }
+  ],
+  "packageName": "@itwin/core-common"
+}
diff --git a/core/common/src/rpc/IModelReadRpcInterface.ts b/core/common/src/rpc/IModelReadRpcInterface.ts
@@ -66,6 +66,7 @@ export abstract class IModelReadRpcInterface extends RpcInterface {
   public async getConnectionProps(_iModelToken: IModelRpcOpenProps): Promise<IModelConnectionProps> { return this.forward(arguments); }
   public async queryRows(_iModelToken: IModelRpcProps, _request: DbQueryRequest): Promise<DbQueryResponse> { return this.forward(arguments); }
   public async queryBlob(_iModelToken: IModelRpcProps, _request: DbBlobRequest): Promise<DbBlobResponse> { return this.forward(arguments); }
+  @RpcOperation.allowResponseCaching(RpcResponseCacheControl.Immutable)
   public async getModelProps(_iModelToken: IModelRpcProps, _modelIds: Id64String[]): Promise<ModelProps[]> { return this.forward(arguments); }
   @RpcOperation.allowResponseCaching(RpcResponseCacheControl.Immutable)
   public async queryModelRanges(_iModelToken: IModelRpcProps, _modelIds: Id64String[]): Promise<Range3dProps[]> { return this.forward(arguments); }