Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into imodel02 #3255

Merged
merged 36 commits into from
Feb 22, 2022
Merged

Merge master into imodel02 #3255

merged 36 commits into from
Feb 22, 2022

Conversation

DanielToby
Copy link
Contributor

No description provided.

pmconne and others added 30 commits February 11, 2022 14:43
* Add context to allow popup toolbar items to autohide

* Add auto-hide login to the toolbar
overflow popup.

* Remove the left, rgith, and top borders from
dockt tool setttings (requested by
UX Standards).

* Add tests for setting hidden attribute
on overflow and tool popup.

* Rush change

* Lint errors

* Extract-api

* Remove unnecessary spaces from SCSS

* Removed unnecessary spaces.

Co-authored-by: bsteinbk <65047615+bsteinbk@users.noreply.github.com>
* Content customization doc enhancements

* Update docs/presentation/Content/PropertyCategorySpecification.md

Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com>

* Update docs/presentation/Content/RendererSpecification.md

Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com>

* Clarify the `PropertyCategorySpecification.id` description

* Update docs/presentation/Content/DefaultPropertyCategoryOverride.md

Co-authored-by: Robert Lukasonok <70327485+roluk@users.noreply.github.com>

* Update docs/presentation/Content/DefaultPropertyCategoryOverride.md

Co-authored-by: Robert Lukasonok <70327485+roluk@users.noreply.github.com>

* Update docs/presentation/Content/PropertySpecification.md

Co-authored-by: Robert Lukasonok <70327485+roluk@users.noreply.github.com>

* Update docs/presentation/Content/RelatedPropertiesSpecification.md

Co-authored-by: Robert Lukasonok <70327485+roluk@users.noreply.github.com>

* Update docs/presentation/Content/PropertyCategorySpecification.md

* Update docs/presentation/Content/PropertySpecification.md

* Update docs/presentation/Content/RelatedPropertiesSpecification.md

Co-authored-by: Robert Lukasonok <70327485+roluk@users.noreply.github.com>

* Update docs/presentation/Content/RelatedPropertiesSpecification.md

Co-authored-by: Robert Lukasonok <70327485+roluk@users.noreply.github.com>

* Improvements for `RelatedPropertiesSpecification.propertiesSource` docs

* Update docs/presentation/Content/PropertySpecification.md

Co-authored-by: karolisab <89905873+karolisab@users.noreply.github.com>

Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com>
Co-authored-by: Robert Lukasonok <70327485+roluk@users.noreply.github.com>
Co-authored-by: karolisab <89905873+karolisab@users.noreply.github.com>
Co-authored-by: Arun George <aruniverse@users.noreply.github.com>
* Check if base units matches for unit conversion and moved conversion tests to test folder

* Added checking base units matches for conversion tests

* Move expected parser data to json file for linting and use deserialize helper method

* Ran rush change and extract-api

* Initial querying units schema

* Changed querying phenomenon to check all schemas in context, added tests

* Changed from passing a filter function to Context to a forEach function for more generalize purposes

* Added initial finding units by display label and alternate display label

* Combined finding units by display label and alternate display label, changed to always return one unit instead of array

* Refactored findUnitByDisplayLabel to be more concise, added some comments, and removed other comments

* Created UnitsProvider using Unit Query and Converter classes, need to address comments

* Adding ecschema-metadata as peer dependency of frontend

* Renamed UnitQuery to UnitProvider, changed to use generator to iterate over schema items, use matchesFullName for full name comparison, added tests for getAlternateDisplayLabels, and added method to check if schemaItem is Unit

* add imodeljs-quantity as devDependency

* move formatEnums to quantity package

* remove duplicate utilities functions from Format

* update imports

* update dependencies versions

* Made common interface for UnitExtraData, added quantity as dependency to ecschema-metadata, and changed NewUnitsProvider to take in UnitExtraData

* remove some unnecessary checks for "undefined"

* add FormatBase class

* update tests errors messages

* Initial integrating new units provider to frontend

* Taking in SchemaContext in QuantityFormatter and IModelApp opts and added mock Units Schema in frontend tests

* Cleaned up linting errors

* Added comments and refactored NewUnitsProvider

* Replaced taking in SchemaContext with taking in UnitsProvider in QuantityFormatter and IModelApp

* Removed ecschema-metadata dependency from frontend and seperated alternate display labels from Unit Definition in BasicUnitsProvider

* Minor tweaks and refactorings

* fix build error

* Moved change made to file prior to relocation

* fixing issues after merge

* Reverting unwanted changes after merge

* reverting unwanted change after merge

* revert files

* Rename UnitProvider and implement interface

* wip

* wip

* wip

* merge with master

* lock file

* added fullstack test

* test failure fix

* test fix

* lint fixes

* api extraction

* lock file

* change logs

* fix dependency errors

* lock file

* docs fix

* use existing test bim for fullstack test

* lock file

* fix for intermittent test failure

* remove before/aftereach

* fixing case issue on linux build

* add way to reset to BasicUnitsProvider (#3167)

* run extract-api

* remove old comment

* remove unneeded imodeljsShardLibrary entry

* remove error prop from UnitConversionSpec

* make ecschema-metadata an optional dependency

* import schema and locater as types

* Eliminate need for caller to reinitialize when setting UnitsProvider

* extrackt-api

* update change log message

* alphabetize packages

* alphabetize more deps and other clean up

Co-authored-by: Ivan Kok <Ivan.Kok@bentley.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Daumantas Jankauskas <47949861+DaumantasJankauskas@users.noreply.github.com>
Co-authored-by: Bill Steinbock <65047615+bsteinbk@users.noreply.github.com>
Co-authored-by: Caleb Shafer <31107829+calebmshafer@users.noreply.github.com>
* Update Timeline to use DropDownMen from itwin-ui instead of ContextMenu.

* extract api
* WIP first round curvature sort step.

* WIP tangent booleans work for test case, but still have problems if rotated.   Starting full circle issue

* Graph construction code after computing intersections did not account for curve portions before and after first and last intersection.

* api

* it.only

* console ok in test

* Enable code that was disabled for debugging

* Remove TODO

* eliminate fixed boolean
* offset circles & ellipses

* B-spline curve xy-offset

* add offset distance spot-checks

* extract-api, it.only

* new CurvePrimitive.constructOffsetXY

* avoid circular ref when compiling tests

* it.only, skip test of clonePartialCurve on Bspline

* simplify changes
* Do not produce illegal filenames on windows.

* lint
* Promote QuantityFormatter to public

* update to mention caching of specs

* Update documentation

* More doc updates and promoting QuantityFormatter to public.

* Update Document

* Suggested edits toi quantity docs. (#3207)

* Add nextversion entry for SchemaUnitProvider

* Update NextVersion

* Add missing doc from public methods of quantityformatter.

* Add doc for all protected entries in QuantityFormatter

* rush change

* Add documentation for each QuantityType enum entry.

* Add documentation for a couple more interfaces used in quantity formatting.

Co-authored-by: NancyMcCallB <45079789+NancyMcCallB@users.noreply.github.com>
* Add frontstageDef.isWidgetDisplayed() to allow
apps to query the visibility of widgets (for data loading)
Undeprecate wrongly-deprecated PanelStateChangedEventArgs
Return WidgetState.Floating from frontstageDef.getCurrentWidgetState()
if the widget is floating

* Rush change

* rush extract-api

* rerun extract-api on branch

* Test coverage

Co-authored-by: bsteinbk <65047615+bsteinbk@users.noreply.github.com>
* Run integration tests on all platforms
* separate pr validation pipeline and add pipeline for full integration test validation
* add autocancel to core ci build
…ng (#3185)

* Fix missing 'iModelJs' namespaces in localization keys.
* Remove call to getLocalizeStringWithNamespace in favor of getLocalizedString.
* Remove second occurrence of getLocalizedStringWithNamespace.
* WIP - Initial settings

* Initial map tile tree changes for BIM layers

* Layer planar classifier creation

* Working version.

* Viewflags for map layers

* Map layer picking WI:

* WIP: Feature id support.

* Fix map layer classifier view falgs

* Set range corners on map tiles tp optimize culling

* Working version with features

* WIP - Working features

* Remove comment

* Fix clip mask

* Handle map layers above max with seperate meshes

* WIP - Layering with interleaved imagery and BIM

* Refine BIM layer tile clipping

* Transparency support for BIM map layers

* Force creation of map layer classifier texture

* Handle BIM layers when base is not imagery

* Remove debugging

* Model layer setting support

* model layer name cleanup

* Revert to single model for map layer

* Fix imports

* Documentation

* Model layer tests

* Fix test -- don't include subLayers if undefined.

* implement getMapLayerRange for model map layers

* Find map layers by source (which may be model id) rather than url

* extract-api

* extract-api

* NextVersion.md WIP -- fix findMapLayerByNameAndSource

* Added Model maplayers support to maplayers widget.

* Fix precision problem with matrix stored as Float32

* extract-api

* Reduce unnecessary allocations - tolerance model map layer overlap

* extract-api

* stop-gap Matrix4d inversion fix

* refine scaling to fix Matrix4d inverse failure

* refine scaling to fix Matrix4d inverse failure

* Fix test for model map layers

* Simplify MapLayerSettings - remove MapLayerSettingBase.  MapLayerProps still needs work

* Remove MapLayerPropsBase

* whitespace

* extract-api

* extract-api

* Remove isBase property.

* Use DialogButtonType from @itwin/appui-abstract instead of @itwin/core-react

* WIP - model map layers documentation

* Ensure v_eyeSpace is available.

* Only set credentials if available.  Always setting it to null will make deep object comparaison fails (i.e. typemoq)

* Handle preemultiplied texture RGB

* Set dimensions of classification texture to match viewport.

* No premultiplied alpha for imagery (non classified) tiles.

* Add map layer images

* Switch map layer images to JPEG

* Make sure the access keys are set to run PlanProjection tests.

* Revert "Make sure the access keys are set to run PlanProjection tests."

This reverts commit 6fc95a2.

* Tests that require bing access key must be integration tests.

* set map layer options; remove unused electronApp options.

* .only

* lint

* docs

Co-authored-by: Ray.Bentley <rbbentley@users.noreply.github.com>
Co-authored-by: Michel Dastous <mdastous-bentley@users.noreply.github.com>
Co-authored-by: dassaf4 <68340676+dassaf4@users.noreply.github.com>
Co-authored-by: Paul Connelly <22944042+pmconne@users.noreply.github.com>
* create spirals beyond [0,1], move clothoid test

* create spirals beyond [0,1], move clothoid test
…#3117)

* addMiteredPipes now handles elliptical sections

* extract-api

* extract-api
* Return RealityDataError on invalid reality data source file

* extract-api
imodeljs-admin and others added 6 commits February 21, 2022 05:01
* support Azure Government tile cache

* changelog

* add unit tests and fix bug

* oops

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* simplify SchemaUnitProvider implementation

* change log and api extraction

* remove or since a context is a locater

* add log message

* update logger category

* another api extraction attempt

* lint fixes
@bentley/imodeljs-native 3.1.6
@pmconne
Copy link
Member

pmconne commented Feb 22, 2022

@williamkbentley is this expected from docs build?

##[error]Error: Not found SourceFolder: D:\vsts_a\20\s\itwinjs-core\generated-docs\clients

@williamkbentley
Copy link
Member

@williamkbentley is this expected from docs build?

##[error]Error: Not found SourceFolder: D:\vsts_a\20\s\itwinjs-core\generated-docs\clients

Yes, that can be safely ignored. Relic from when clients used to be in the main repo and having to keep that build step around for <v3 builds. I tried to fix it before, but I learned that the "Copy files" task does not have custom conditions.

@pmconne pmconne merged commit 17ac67e into imodel02 Feb 22, 2022
@pmconne pmconne deleted the imodel02-merge-master branch February 22, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.