Merge 'master' branch into 'io-fix-build-to-yaml' #3340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bol (#2998) * Honor "None" and "No Symbol" for MessageBox components * Update testing * extract-api
Co-authored-by: Paul Connelly <22944042+pmconne@users.noreply.github.com>
… RealityDataAccess client. (#2952) * Create integration tests (full stack tests) for RealityDataSource and RealityDataAccess client. * Put back package in alphabetical order * Add changelog
* Sky cube primitive buffers must be bound when attempting to draw a sky cube. * Revert adjustZPlanes globe change. * rush extract-api * rush change * changelog unneeded for regression that was never released. Co-authored-by: Paul Connelly <22944042+pmconne@users.noreply.github.com>
* optimize matrix calculation * optimize matrix calculation * remove vague changelog of no interest to package consumers Co-authored-by: Paul Connelly <22944042+pmconne@users.noreply.github.com>
…3003) * Unregister maplayers itemsProvider and widget control on termine * Added changelog. * Dont register Widget control. * Fix lint errors.
* Remove the `@bentley/itwin-client` package * Roll the request wrappers into packages that need it, including imodelhub client, core-mobile and core-frontend Co-authored-by: Paul Connelly <22944042+pmconne@users.noreply.github.com>
* Fix bug where new releases of old versions would get 'latest' tag * delete unused variables * Update dist tag logic * Improve logic for giving out 'previous' tag * Fix bugs and add comments to dist tag script * Handle empty versions
* option to specify geomstream as builder data on element/update * wip * more tests for elementGeometryBuilderParams when used by insert and update * wip roughing in support for elementGeometryBuilderParams in geom parts * mark new elementGeometryBuilderParams properties alpha * wip elementGeometryBuilderParams for geometry parts * extract-api * rush change * Distinguish element geometry builder params for parts from params for geometric elements * rush extract-api * Missing @Alpha tag on new prop * Wrong type for elementGeometryBuilderParams * extract-api
* Add a test to reproduce selection set becoming empty due to unified selection after clearing and replacing selection set * Fix unified selection tests to wait not only for `unified -> viewport` selection, but also for `viewport -> unified` selection to be synced * Fix hilite set being cached with wrong guid * rush change
* readImageBuffer. * Allow absolute viewport position so view rect can be precisely specified in pixels. * testBlankViewport * Test proving readImage reads upside-down. * Test inverted y in view rect. * Corresponding readImageBuffer tests. * Implement readImageBuffer; tests pass. * docs, rename. * deprecate RenderTarget.readImage too. * tests * finish up tests. * doc. * NextVersion.md * fix up callers of readImage. * update test for correct behavior. * update a couple more tests. * extract-api * doc is lie. * completely unimportant typo.
naveedkhan8067
requested review from
a team,
bbastings,
EarlinLutz,
mgooding,
RBBentley,
dassaf4,
Ellord207,
calebmshafer,
wgoehrig,
kabentley,
ramanujam-raman-zz,
ColinKerr,
aruniverse,
jchick-bentley,
bsteinbk,
mdastous-bentley,
diegoalexdiaz,
pmconne,
MichaelBelousov,
paulius-valiunas,
amikoliunas and
Animagne
as code owners
Co-authored-by: Arun George <aruniverse@users.noreply.github.com>
|
Just trying to understand this, why is the YAML thats used to generate/validate core docs not on master? Do we generate/validate/publish docs from a branch and not master? |
|
@aruniverse it's been in a holding pattern for a while. We need to do some work on the pipeline side for releasing the docs that way. I'm hoping we can get to that in the next couple weeks. @skirby1996 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The branch 'io-fix-build-to-yaml' has the YAML that is used to generate and validate the itwinjs-core docs. Currently, build is failing as the branch is not sync with master that has the latest fixes for docs according to the new version of '@bentley/bemetalsmith'