Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close popup when the widget tab is clicked #3685

Merged
merged 5 commits into from
May 27, 2022
Merged

Close popup when the widget tab is clicked #3685

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6823bb4
Allow tippy.js to close the popup when the tab is clicked.
GerardasB May 24, 2022
a1b5bd6
Prevent browser drag interaction when dragging a tab.
GerardasB May 25, 2022
b8c8d50
Allow tippy.js to close the popup when the widget is resized.
GerardasB May 25, 2022
2af888a
Rush change.
GerardasB May 25, 2022
681a1bd
Tests.
GerardasB May 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/@itwin/appui-layout-react/widget-tab-tippy_2022-05-25-13-12.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@itwin/appui-layout-react",
"comment": "Allow tippy.js to close when tab is clicked.",
"type": "none"
}
],
"packageName": "@itwin/appui-layout-react"
}
1 change: 0 additions & 1 deletion ui/appui-layout-react/src/appui-layout-react/base/DragHandle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ export class DragHandle extends React.PureComponent<DragHandleProps, DragHandleS

this.setState({ isPointerDown: true });

e.preventDefault();
this._isDragged = false;
this._initial = new Point(e.clientX, e.clientY);
};
Expand Down
7 changes: 6 additions & 1 deletion ui/appui-layout-react/src/appui-layout-react/base/PointerCaptor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,12 @@ export class PointerCaptor extends React.PureComponent<PointerCaptorProps> {
style={this.props.style}
role="presentation"
>
<div className="nz-overlay" />
<div
className="nz-overlay"
onDragStart={(e)=> {
e.preventDefault();
}}
/>
{this.props.children}
</div>
);
Expand Down
1 change: 0 additions & 1 deletion ui/appui-layout-react/src/appui-layout-react/widget/rectangular/ResizeGrip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ export class ResizeGrip extends React.PureComponent<ResizeGripProps, ResizeGripS
this._lastPosition = new Point(e.clientX, e.clientY);

this._isResizing = true;
e.preventDefault();

const bounds = Rectangle.create(grip.getBoundingClientRect());
this.props.onResizeStart && this.props.onResizeStart({
Expand Down