Presentation: Introduce nth level element selection scope support #3743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roluk
requested changes
Jun 3, 2022
presentation/backend/src/presentation-backend/SelectionScopesHelper.ts
Outdated
Show resolved
Hide resolved
presentation/backend/src/presentation-backend/SelectionScopesHelper.ts
Outdated
Show resolved
Hide resolved
presentation/common/src/presentation-common/PresentationRpcInterface.ts
Outdated
Show resolved
Hide resolved
presentation/frontend/src/presentation-frontend/selection/SelectionScopesManager.ts
Outdated
Show resolved
Hide resolved
roluk
approved these changes
Jun 6, 2022
calebmshafer
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves itwin/itwinjs-backlog#164.
Introduced a new type
ComputeSelectionScopePropsthat has anidattribute for available scopes and also has aparams: { level: number }attribute for the scope withid: "element". On the frontend objects of this new type can now be set onPresentation.selection.scopes.activeScopeor passed toPresentation.selection.scopes.activeScope.computeSelection. This allows passing the level of requested ancestor when using "element" scope.The PR also increases minor version of
PresentationRpcInterfaceto make sure new frontends don't request old backends to compute selection in the new way and assume the backends handles the added params. Old frontends can still safely use updated backends.