Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up build pipelines #4995

Merged
merged 20 commits into from
Jan 31, 2023
Merged

Clean up build pipelines #4995

merged 20 commits into from
Jan 31, 2023

Conversation

calebmshafer
Copy link
Member

@calebmshafer calebmshafer commented Jan 29, 2023

  • Fix Node 12 compatibility issues with using fs.rmSync. This API did not get added until v14.14 and v16.14.
  • Fix the public ci build
  • Ensure consistent Node versions
    • The regression testing was checking the latest Node version (18) instead of that being the main CI build.
  • Redundant info being set in the fast-ci.yaml vs. ci.yaml
  • Update minimum Node 12 version tested with, only support >12.22 so no need to test earlier versions.
  • Allow integration regression to scale out to as many agents as possible for quick turnaround. Uses standard Azure pool, not the custom pool.

The following builds are not run directly on PR builds but do need to be validated as they're performing regression testing and other validation that takes longer than we'd like to wait for each one.

  • Regression build
  • Integration tests
  • Integration regression tests
  • iOS tests

Regression test run: https://dev.azure.com/bentleycs/iModelTechnologies/_build/results?buildId=1926713&view=results
Integration regression: https://dev.azure.com/bentleycs/iModelTechnologies/_build/results?buildId=1926767&view=results

@calebmshafer calebmshafer requested a review from a team as a code owner January 29, 2023 14:09
@calebmshafer
Copy link
Member Author

@raplemie @GerardasB @NancyMcCallB looks like there are a couple issues with the CI now that I switched it to the latest Node 18 version. Can you take a look?

--[ FAILURE: @itwin/components-react ]--------------[ 1 minute 20.2 seconds ]--

undefined
Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://reactjs.org/link/unsafe-component-lifecycles for details.

* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://reactjs.org/link/derived-state
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 18.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: ReactDataGrid, Viewport, t
Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://reactjs.org/link/unsafe-component-lifecycles for details.

  ...285 lines omitted...
      at waitForWrapper (D:\vsts_a\4\s\common\temp\node_modules\.pnpm\@testing-library+dom@8.20.0\node_modules\@testing-library\dom\dist\wait-for.js:166:27)
      at Context.<anonymous> (src\test\editors\DateTimeEditor.test.tsx:257:25)
      at processImmediate (node:internal/timers:471:21)



ERROR: Coverage for lines (99.89%) does not meet global threshold (100%)
ERROR: Coverage for functions (99.89%) does not meet global threshold (100%)
ERROR: Coverage for branches (99.93%) does not meet global threshold (100%)
ERROR: Coverage for statements (99.9%) does not meet global threshold (100%)

--[ FAILURE: @itwin/imodel-components-react ]--------[ 1 minute 7.2 seconds ]--


  288 passing (30s)
  1 failing

  1) <TimelineComponent showDuration={true} />
       should respect time zone offset:

      AssertionError: expected '07:00:00\u202fPM' to equal '07:00:00 PM'
      + expected - actual

      -07:00:00 PM
      +07:00:00 PM
      
      at Context.<anonymous> (src\test\timeline\TimelineComponent.test.tsx:889:41)
      at processImmediate (node:internal/timers:471:21)

@calebmshafer calebmshafer requested a review from a team as a code owner January 29, 2023 16:17
@aruniverse aruniverse requested a review from a team as a code owner January 30, 2023 19:38
@aruniverse
Copy link
Member

@raplemie @GerardasB @NancyMcCallB looks like there are a couple issues with the CI now that I switched it to the latest Node 18 version. Can you take a look?

--[ FAILURE: @itwin/components-react ]--------------[ 1 minute 20.2 seconds ]--

undefined
Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://reactjs.org/link/unsafe-component-lifecycles for details.

* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://reactjs.org/link/derived-state
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 18.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: ReactDataGrid, Viewport, t
Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://reactjs.org/link/unsafe-component-lifecycles for details.

  ...285 lines omitted...
      at waitForWrapper (D:\vsts_a\4\s\common\temp\node_modules\.pnpm\@testing-library+dom@8.20.0\node_modules\@testing-library\dom\dist\wait-for.js:166:27)
      at Context.<anonymous> (src\test\editors\DateTimeEditor.test.tsx:257:25)
      at processImmediate (node:internal/timers:471:21)



ERROR: Coverage for lines (99.89%) does not meet global threshold (100%)
ERROR: Coverage for functions (99.89%) does not meet global threshold (100%)
ERROR: Coverage for branches (99.93%) does not meet global threshold (100%)
ERROR: Coverage for statements (99.9%) does not meet global threshold (100%)

--[ FAILURE: @itwin/imodel-components-react ]--------[ 1 minute 7.2 seconds ]--


  288 passing (30s)
  1 failing

  1) <TimelineComponent showDuration={true} />
       should respect time zone offset:

      AssertionError: expected '07:00:00\u202fPM' to equal '07:00:00 PM'
      + expected - actual

      -07:00:00 PM
      +07:00:00 PM
      
      at Context.<anonymous> (src\test\timeline\TimelineComponent.test.tsx:889:41)
      at processImmediate (node:internal/timers:471:21)

nodejs/node#46123

@aruniverse aruniverse merged commit f17bf71 into master Jan 31, 2023
@aruniverse aruniverse deleted the fix-public-ci branch January 31, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants