add setKindOfQuantity api (backport #7090) [release/4.8.x]
#7110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
mergify
bot
requested review from
calebmshafer,
ColinKerr,
wgoehrig,
christophermlawson and
StefanApfel-Bentley
as code owners
|
@aruniverse Carole requested this backport for new API. She says she has to use a Desktop app for her work which is just now moving to 4.8.x. Do we typically backport for this? Should I tell her we can't do it? |
I'm kinda worried about the breaking changes in here wrt to the enum status |
|
@aruniverse It is marked as alpha. We've already changed this enum to a string enum, but this PR just missed that unfortunately. |
ColinKerr
approved these changes
Aug 26, 2024
aruniverse
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #7090 done by [Mergify](https://mergify.com).