-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass includeIncomplete flag to queryGraphicRepresentations #7145
Conversation
/azp run iTwin.js |
/azp run iTwin.js Docs - YAML |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run iTwin.js Integration - GitHub |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Currently waiting on PR #7146 that updates packages to fix the failing rush audit and extract API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mock tests LGTM
@Mergifyio backport release/4.8.x |
✅ Backports have been created
|
(cherry picked from commit 3650272)
queryMeshExports
, even when they should be included via theincludeIncomplete
flag_links
property. Fixed by checking if_links
is undefined.GraphicRepresentationStatus
enum is outdated to what statuses the mesh export service can return. This does not throw an error anywhere, but it should be addressed in a future PR.