Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass includeIncomplete flag to queryGraphicRepresentations #7145

Merged
merged 6 commits into from
Sep 12, 2024

Conversation

eringram
Copy link
Member

@eringram eringram commented Sep 10, 2024

  • Fixed a bug in FrontendTiles.ts that prevented exports with a status other than "Complete" from being returned by queryMeshExports, even when they should be included via the includeIncomplete flag
  • Added unit tests for this
  • Also fixed a related issue where because we were assuming all exports were complete, we were also assuming they all had a _links property. Fixed by checking if _links is undefined.
  • Added a note that the GraphicRepresentationStatus enum is outdated to what statuses the mesh export service can return. This does not throw an error anywhere, but it should be addressed in a future PR.

@eringram eringram marked this pull request as ready for review September 10, 2024 23:01
@eringram eringram requested review from danieliborra and a team as code owners September 10, 2024 23:01
@eringram
Copy link
Member Author

/azp run iTwin.js

@eringram
Copy link
Member Author

/azp run iTwin.js Docs - YAML

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eringram
Copy link
Member Author

/azp run iTwin.js Integration - GitHub

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@markschlosseratbentley markschlosseratbentley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eringram
Copy link
Member Author

eringram commented Sep 11, 2024

Currently waiting on PR #7146 that updates packages to fix the failing rush audit and extract API

Copy link
Contributor

@andremig-bentley andremig-bentley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mock tests LGTM

@eringram eringram merged commit 3650272 into master Sep 12, 2024
17 checks passed
@eringram eringram deleted the eringram/frontend-tiles-bugfix branch September 12, 2024 20:13
@eringram
Copy link
Member Author

@Mergifyio backport release/4.8.x

Copy link
Contributor

mergify bot commented Sep 12, 2024

backport release/4.8.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants