Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async worker return type (backport #7249) [release/4.9.x] #7250

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 9, 2024

Fixes #7248.

#7088 enabled support for asynchronous implementations of individual worker operations, to prevent long-running operations from blocking subsequent requests. But, the types did not accurately capture these semantics, so you couldn't return { result: T, transfer: Transferable[] } from async implementations without the compiler complaining. It would expect you to return { result: Promise<T>, transfer: Transferable[] } instead.

Adjusted the types to fix this.


This is an automatic backport of pull request #7249 done by Mergify.

@mergify mergify bot requested a review from bbastings as a code owner October 9, 2024 16:12
@mergify mergify bot assigned pmconne Oct 9, 2024
@mergify mergify bot requested review from aruniverse, ben-polinsky and a team as code owners October 9, 2024 16:12
@mergify mergify bot mentioned this pull request Oct 9, 2024
@aruniverse aruniverse enabled auto-merge (squash) October 9, 2024 16:12
@mergify mergify bot requested a review from a team October 9, 2024 16:13
@pmconne pmconne disabled auto-merge October 9, 2024 17:11
@pmconne pmconne merged commit 850dd9a into release/4.9.x Oct 9, 2024
15 of 16 checks passed
@pmconne pmconne deleted the mergify/bp/release/4.9.x/pr-7249 branch October 9, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants