-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
documentation: fix link to isInUseLocksError #7394
Conversation
Has the oversight been fixed? Are we confident no other instances of this same error exist elsewhere in the docs? |
In progress. Link issues were still being logged, but builds would not fail because of them. I'll push a new version of bemetalsmith without this check.
Yes. The warnings would still be logged. Currently we have a couple changehistory warnings, but those are ok and expected if we remove an API. (They probably shouldn't be logged to avoid confusion.) Otherwise, there is one last warning which I am trying to track down |
@Mergifyio backport release/4.11.x release/4.10.x |
✅ Backports have been created
|
Co-authored-by: Ben Polinsky <ben-polinsky@users.noreply.github.com> (cherry picked from commit 5e617a5)
Co-authored-by: Ben Polinsky <ben-polinsky@users.noreply.github.com> (cherry picked from commit 5e617a5)
…e/4.10.x] (#7396) Co-authored-by: Ben Polinsky <78756012+ben-polinsky@users.noreply.github.com>
…e/4.11.x] (#7395) Co-authored-by: Ben Polinsky <78756012+ben-polinsky@users.noreply.github.com>
Links to namespace children must be prefaced by namespace name, even when inside of the namespace. Docs link validation failed to catch this error due an oversight in easing the upgrade to TypeScript 5.3/TypeDoc 0.24.x.