-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handling commas and dots input in parseToken of Parser #7514
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mathieu-fournier I'll let you chime in on whether we should check only commas and dots, or check all special characters (and if the special characters mentioned are enough or we missing any)
Just pushed a slightly different fix because Mathieu asked to handle multiple dots and comas mixed into numbers
the ones with comas is a bit tricky
the parsing skips comas because the parsing method thinks its a thousands separator so it ignores it, will look into it more. |
#7487
Right now I have any input consists only special characters returning a parseError or a quantity with isValid field being false.
this should be all the special characters.
/^[!@#$%^&*()_+-=[]{};':"\|,.<>/?]+$/;
Let me know if thats expected, or we wanna handle just the dots/comas occurrences