-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump to @bentley/react-scripts@4.0.3, eslint@^7.11.0 #942
Conversation
Can you elaborate? Are the test-apps broken in some way? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aruniverse before we merge this, we'll want to make sure to merge the CRA 4 PR in our fork and get an official version published. I'll review that later today.
I believe there's an issue with auth in ui-test-app that @ramanujam-raman is actively working on. There's also the breaking electron rpc changes changes in 2.13 Paul i did test the display-test-app, i was able to open a local model, and everything seemed to work, but not too familiar with the app to test it thoroughly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving display-test-app changes...can't comment on CRA stuff.
Bumping @bentley/react-scripts to 4.0.3, see imodeljs/create-react-app#35
Moved some of the flags from the package.json scripts into an
.env
file, users can override it with a.env.*.local
file with different setting for development or production builds in a.env.development
or.env.production
fileThe core monorepo is using
react@16.14.0
which supports the new react-jsx transform, but we couldn't use it until typescript was bumped to 4.1 or we bumped react-scripts to 4.0.0. I have explicitly disabled the use of this new transform, but we can re-enable later. Currently there is an issue using that feature because we pin down our@types/react
down to 16.9.43 and its missing the type for the transform. "Could not find a declaration file for module 'react/jsx-runtime'"Eitherway, with this change, everything still compiles. Due to outstanding issues with the test-apps w.r.t breaking changes in 2.13.x i was unable to test it out thoroughly, but everything should be fine.