Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jQuery dependency #12

Closed
jri opened this issue Apr 7, 2019 · 2 comments
Closed

Remove jQuery dependency #12

jri opened this issue Apr 7, 2019 · 2 comments

Comments

@jri
Copy link

jri commented Apr 7, 2019

This extension's README lies about dependencies. It does not mention the jQuery dependency. Today for a lot of developers having jQuery as a dependency is quite unattractive resp. unacceptable.

The jQuery dependency should be removed. This extension uses jQuery merely to measure width/height of a DOM element, which might not justify adding such a "deprecated" library to ones project.

The autopan extension seems to be quite useful and just needs some minor "modernization".
@ugurdogrusoz
Copy link
Contributor

Feel free to get rid of the dependency with a PR.

jri added a commit to jri/cytoscape.js-autopan-on-drag that referenced this issue Apr 8, 2019
@jri
Remove jQuery dependency (iVis-at-Bilkent#12)
b895c52
@jri
Copy link
Author

jri commented Apr 9, 2019

@kinimesi thank you for removing jQuery!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jri @ugurdogrusoz