Fixing some behaviors when there's no context menu on cytoscape background. #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 16, 2022 11:49
… in cytoscape background. In this case, target variable is cytoscape itself, and it does not have the method is().
When show context menu over edge, show the menu with one item. When call event directly on background, without closing the menu before, show a context menu with no item, but it's possible to see the borders. This happens because this function, that is failing in checking element visibility. Accordingly to "http://code.jquery.com/jquery-latest.js", it should check if the display style is equal 'none' instead checking if only existis. In my case, the style.display was block, and it was returning true for isElementHidden.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys, I would like to suggest this two fixes for issues that I found using your library. At the moment I'm doing some hacks in my code to use your library without fork it, but I guess that other people could make use of this.