-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow grouping all measurements into one with multiple fields #116
Conversation
Our organization needs to group all the fields under one measurement and transmit them as one measurement. This alternate serialization can be had by instantiating GroupedInfluxDbHttpSender instead of InfluxDbHttpSender. TODO: update unit tests to cover the new code.
…class. This is cleaner.
Merge the mnp repository with the latest.
…re one of the methods in InfluxDbHttpSender
…mples, but then decided to provide one example with multiple points but forgot to update the tense of the sentence before the example.
…s. Understanding how the code works better, all measurements share the same tags and my example showed points with different tags which is not possible.
@rickard-von-essen-iz - Could you please let me know if this PR suffices to meet the doc requirements from October of 2017? Is there anything else you'd like me to add or make more clear? |
I'm going to tag everyone listed under contributors since review of this PR doesn't appear to be moving forward. If this is not the right thing to do, I apologize. |
Hi @tmousaw-ptc I applaud the persistence! Let's get this merged finally 🍰 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks for contributing @tmousaw-ptc ! |
Yes tomorrow thanks @izrobin this and the osspom too I think |
This is an attempt to get a change done by our company finally merged into the latest. See #72 for details on what this pull request is based on.
Here is the description from the original PR:
There was a comment made by @rickard-von-essen-iz on 10/17/2017 requesting that a detailed documentation. This PR adds that detailed documentation and also merged in master from the main branch to bring it up to version 1.3.0 (it was based off version 1.1.9).
Please review and let me know if this needs further details/further work.