Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow grouping all measurements into one with multiple fields #116

Merged
merged 15 commits into from
Apr 7, 2020

Conversation

tmousaw-ptc
Copy link
Contributor

This is an attempt to get a change done by our company finally merged into the latest. See #72 for details on what this pull request is based on.

Here is the description from the original PR:

Our organization needs to group all the fields under one measurement and transmit them as one measurement. This alternate serialization can be had by instantiating GroupedInfluxDbHttpSender instead of InfluxDbHttpSender.

There was a comment made by @rickard-von-essen-iz on 10/17/2017 requesting that a detailed documentation. This PR adds that detailed documentation and also merged in master from the main branch to bring it up to version 1.3.0 (it was based off version 1.1.9).

Please review and let me know if this needs further details/further work.

@coveralls
Copy link

coveralls commented Feb 29, 2020

Coverage Status

Coverage increased (+1.5%) to 80.435% when pulling 9ee5b77 on tmousaw-ptc:master into e646232 on iZettle:master.

…mples, but then decided to provide one example with multiple points but forgot to update the tense of the sentence before the example.
…s. Understanding how the code works better, all measurements share the same tags and my example showed points with different tags which is not possible.
@tmousaw-ptc
Copy link
Contributor Author

@rickard-von-essen-iz - Could you please let me know if this PR suffices to meet the doc requirements from October of 2017? Is there anything else you'd like me to add or make more clear?

@tmousaw-ptc
Copy link
Contributor Author

I'm going to tag everyone listed under contributors since review of this PR doesn't appear to be moving forward. If this is not the right thing to do, I apologize.
@nzroller @ngong @sirtik @rickard-von-essen-iz @izrobin @BertiliZ @shanielh @mmatloka @johndashbase @xiaodong-izettle @ri-boris @jjungnickel @hfreire @fredrikbackstrom @eksd @arteam @alorlea

@pp-tim
Copy link
Contributor

pp-tim commented Apr 7, 2020

Hi @tmousaw-ptc I applaud the persistence! Let's get this merged finally 🍰

Copy link
Contributor

@pp-tim pp-tim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@robinjhector
Copy link
Contributor

Thanks for contributing @tmousaw-ptc !
@pp-tim let me know if you need help releasing

@pp-tim
Copy link
Contributor

pp-tim commented Apr 7, 2020

Yes tomorrow thanks @izrobin this and the osspom too I think

@xiao-pp xiao-pp mentioned this pull request Feb 16, 2021
@robinjhector robinjhector mentioned this pull request Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants