refactor(server): decouple Dropwizard resources from JAX-RS contract interfaces #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fushar
force-pushed
the
remove-jaxrs-interface
branch
from
4da2342
to
0073539
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, each Dropwizard resource implements a corresponding interface, which declare the endpoint using JAX-RS contract. This was primarily so that the integration tests can just create a Feign client using the same contract easily.
There are some problems with it:
@Context UriInfoto the resources, which had no corresponding JAX-RS contract (of course)To alleviate the problem, and to future-proof the resources, this PR decouples them.
The next step is to just use Feign contract in the integration tests (not JAX-RS).