Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in lib.rs #65

Merged
merged 1 commit into from
May 20, 2023
Merged

Fix typo in lib.rs #65

merged 1 commit into from
May 20, 2023

Conversation

Munksgaard
Copy link
Contributor

An extra word has snuck in.

Copy link
Owner

@ia0 ia0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Munksgaard for the pull request!

That's actually not a typo. That's me being bad at English. Which means there are other occurrences of this issue throughout the file. You can find them by searching for conform. Would you mind fixing them too? Otherwise I'm happy to merge this and do it myself in a followup PR.

I guess the following substitutions are needed:

  • "It is conform to" becomes "It conforms to"
  • "It is not exactly conform to" becomes "It does not exactly conform to"

At the same time, could you also update the lib/CHANGELOG.md file by adding a line after the first ### Patch header? For example: "- Fix English in documentation".

Thanks!

@Munksgaard
Copy link
Contributor Author

Thank you @ia0 for the suggestions. I apologize for the long wait, but I have just pushed a new commit that addresses all the instances of "conforms", a little rewording in the beginning (if you don't like it I'll remove it again) and an addition to the changelog.

Copy link
Owner

@ia0 ia0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That's all good.

@ia0 ia0 merged commit 0fe84fa into ia0:master May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants