fix: 'parse_race' raising exception instead of returning None

iagocanalejas · Apr 3, 2024 · 2ca64c5 · 2ca64c5
1 parent 9612e04
commit 2ca64c5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/rscraping/parsers/html/abe.py b/rscraping/parsers/html/abe.py
@@ -37,7 +37,8 @@ def parse_race(self, selector: Selector, *, race_id: str, **_) -> Race | None:
         t_date = find_date(name)
 
         if not t_date:
-            raise ValueError(f"{self.DATASOURCE}: no date found for {name=}")
+            logger.error(f"{self.DATASOURCE}: no date found for {name=}")
+            return None
 
         normalized_names = normalize_name_parts(normalize_race_name(name))
         if len(normalized_names) == 0:

diff --git a/rscraping/parsers/html/act.py b/rscraping/parsers/html/act.py
@@ -45,7 +45,8 @@ def parse_race(self, selector: Selector, *, race_id: str, is_female: bool, **_)
 
         t_date = find_date(name)
         if not t_date:
-            raise ValueError(f"{self.DATASOURCE}: no date found for {name=}")
+            logger.error(f"{self.DATASOURCE}: no date found for {name=}")
+            return None
 
         gender = GENDER_FEMALE if is_female else GENDER_MALE
 

diff --git a/rscraping/parsers/html/traineras.py b/rscraping/parsers/html/traineras.py
@@ -66,7 +66,8 @@ def parse_race(self, selector: Selector, *, race_id: str, table: int | None = No
         distance = self.get_distance(selector)
 
         if not t_date:
-            raise ValueError(f"{self.DATASOURCE}: no date found for {name=}")
+            logger.error(f"{self.DATASOURCE}: no date found for {name=}")
+            return None
 
         if not name:
             logger.error(f"{self.DATASOURCE}: no race found for {race_id=}")