#85 - SonarIssue: moving constant to enum

iakunin · Apr 25, 2020 · 01f780b · 01f780b
1 parent 5780f6d
commit 01f780b
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 4 deletions.
diff --git a/src/main/java/dev/iakunin/codexiabot/codexia/cron/ResendReviewsUntilDuplicated.java b/src/main/java/dev/iakunin/codexiabot/codexia/cron/ResendReviewsUntilDuplicated.java
@@ -23,7 +23,7 @@ public void run() {
         this.codexiaReviewNotificationRepository
             .findAllByLastStatusExcludingResponseCode(
                 CodexiaReviewNotification.Status.SUCCESS,
-                CodexiaClient.REVIEW_ALREADY_EXISTS_STATUS
+                CodexiaClient.ReviewStatus.ALREADY_EXISTS.httpStatus()
             )
             .stream()
             .map(CodexiaReviewNotification::getCodexiaReview)

diff --git a/src/main/java/dev/iakunin/codexiabot/codexia/sdk/CodexiaClient.java b/src/main/java/dev/iakunin/codexiabot/codexia/sdk/CodexiaClient.java
@@ -23,8 +23,6 @@
 )
 public interface CodexiaClient {
 
-    int REVIEW_ALREADY_EXISTS_STATUS = 404;
-
     @GetMapping(
         value = "/recent.json",
         produces = { "application/json" }
@@ -73,4 +71,18 @@ class Project {
         // @todo #6 replace `Date` with `ZonedDateTime`
         private Date created;
     }
+
+    enum ReviewStatus {
+        ALREADY_EXISTS(404);
+
+        private final int httpStatus;
+
+        ReviewStatus(int httpStatus) {
+            this.httpStatus = httpStatus;
+        }
+
+        public int httpStatus() {
+            return this.httpStatus;
+        }
+    }
 }
diff --git a/src/main/java/dev/iakunin/codexiabot/codexia/service/ReviewSenderImpl.java b/src/main/java/dev/iakunin/codexiabot/codexia/service/ReviewSenderImpl.java
@@ -70,7 +70,7 @@ private void saveExceptionalNotification(
             notification
                 .setStatus(
                     // @todo #19 rewrite via custom Feign exceptions
-                    e.status() == CodexiaClient.REVIEW_ALREADY_EXISTS_STATUS
+                    e.status() == CodexiaClient.ReviewStatus.ALREADY_EXISTS.httpStatus()
                         ? CodexiaReviewNotification.Status.SUCCESS
                         : CodexiaReviewNotification.Status.ERROR
                 )