#6 - Another more integration tests for StarsUp bot

src/main/java/dev/iakunin/codexiabot/bot/StarsUp.java

@@ -65,17 +65,10 @@ public void run() {
             .forEach(this::processStatList)
         ;
 
-
-        // Тест-кейсы с двумя последовательными запусками с изменениями состояния бота (бот сработал)
-        // Тест-кейсы с двумя последовательными запусками с изменениями состояния github-статистики
-        //    (бот может как сработать, так и нет)
-
-
-        // - Remote-call exception with transaction rollback
-
         log.info("Exiting from {}", this.getClass().getName());
     }
 
+    // @todo #6 add test case with transaction rollback
     @Transactional
     protected void processStatList(Deque<GithubRepoStat> deque) {
         final GithubRepoStat first = deque.getFirst();
@@ -114,6 +107,11 @@ protected void processStatList(Deque<GithubRepoStat> deque) {
                     )
             );
 
+        this.starsUpResultRepository.save(
+            new StarsUpResult()
+                .setGithubRepo(last.getGithubRepo())
+                .setGithubRepoStat(last)
+        );
         this.codexiaModule.sendReview(review);
         this.codexiaModule.sendMeta(
             review.getCodexiaProject(),
@@ -124,11 +122,6 @@ protected void processStatList(Deque<GithubRepoStat> deque) {
                 .map(CodexiaReview::getReason)
                 .collect(Collectors.joining(","))
         );
-        this.starsUpResultRepository.save(
-            new StarsUpResult()
-                .setGithubRepo(last.getGithubRepo())
-                .setGithubRepoStat(last)
-        );
     }
 
     private boolean shouldReviewBeSubmitted(GithubApi firstStat, GithubApi lastStat) {

src/main/resources/META-INF/spring-configuration-metadata.json

@@ -35,6 +35,11 @@
       "type": "java.lang.String",
       "description": "Cron expression for bot.found-on-hackernews."
     },
+    {
+      "name": "app.cron.bot.stars-up",
+      "type": "java.lang.String",
+      "description": "Cron expression for bot.stars-up."
+    },
     {
       "name": "app.cron.bot.found-on-reddit",
       "type": "java.lang.String",

src/main/resources/application-prod.properties

@@ -1,5 +1,6 @@
 app.cron.bot.found-on-hackernews=5 * * * * *
 app.cron.bot.found-on-reddit=55 * * * * *
+app.cron.bot.stars-up=0 30 * * * *
 
 app.cron.codexia.codexia-parser=45 * * * * *
 app.cron.codexia.missing-filler=0 0 0 * * *

src/test/java/dev/iakunin/codexiabot/bot/StarsUpIntegrationTest.java

@@ -132,4 +132,70 @@ public void noStarsUpResults_githubRepoWithTwoStats_happyPath() {
     public void noStarsUpResults_githubRepoWithThreeStats_happyPath() {
         starsUp.run();
     }
+
+    @Test
+    @Transactional
+    @DataSet(
+        value = "db-rider/bot/initial/oneStarsUpResult_githubRepoWithThreeStats_happyPath.yml",
+        cleanAfter = true, cleanBefore = true, disableConstraints = true
+    )
+    @ExpectedDataSet("db-rider/bot/expected/oneStarsUpResult_githubRepoWithThreeStats_happyPath.yml")
+    public void oneStarsUpResult_githubRepoWithThreeStats_happyPath() {
+        starsUp.run();
+    }
+
+    @Test
+    @Transactional
+    @DataSet(
+        value = "db-rider/bot/initial/oneStarsUpResult_githubRepoWithFourStats_happyPath.yml",
+        cleanAfter = true, cleanBefore = true, disableConstraints = true
+    )
+    @ExpectedDataSet("db-rider/bot/expected/oneStarsUpResult_githubRepoWithFourStats_happyPath.yml")
+    public void oneStarsUpResult_githubRepoWithFourStats_happyPath() {
+        starsUp.run();
+    }
+
+    @Test
+    @Transactional
+    @DataSet(
+        value = "db-rider/bot/initial/oneStarsUpResult_noNewGithubStats.yml",
+        cleanAfter = true, cleanBefore = true, disableConstraints = true
+    )
+    @ExpectedDataSet("db-rider/bot/expected/oneStarsUpResult_noNewGithubStats.yml")
+    public void oneStarsUpResult_noNewGithubStats() {
+        starsUp.run();
+    }
+
+    @Test
+    @Transactional
+    @DataSet(
+        value = "db-rider/bot/initial/oneStarsUpResult_starsDecrease.yml",
+        cleanAfter = true, cleanBefore = true, disableConstraints = true
+    )
+    @ExpectedDataSet("db-rider/bot/expected/oneStarsUpResult_starsDecrease.yml")
+    public void oneStarsUpResult_starsDecrease() {
+        starsUp.run();
+    }
+
+    @Test
+    @Transactional
+    @DataSet(
+        value = "db-rider/bot/initial/oneStarsUpResult_starsIncreaseLessThan10.yml",
+        cleanAfter = true, cleanBefore = true, disableConstraints = true
+    )
+    @ExpectedDataSet("db-rider/bot/expected/oneStarsUpResult_starsIncreaseLessThan10.yml")
+    public void oneStarsUpResult_starsIncreaseLessThan10() {
+        starsUp.run();
+    }
+
+    @Test
+    @Transactional
+    @DataSet(
+        value = "db-rider/bot/initial/oneStarsUpResult_starsIncreaseMoreThan10ButLessThan5Percents.yml",
+        cleanAfter = true, cleanBefore = true, disableConstraints = true
+    )
+    @ExpectedDataSet("db-rider/bot/expected/oneStarsUpResult_starsIncreaseMoreThan10ButLessThan5Percents.yml")
+    public void oneStarsUpResult_starsIncreaseMoreThan10ButLessThan5Percents() {
+        starsUp.run();
+    }
 }

src/test/resources/db-rider/bot/expected/emptyDatabase.yml

@@ -1,3 +1,3 @@
-stars_up_result:
+stars_up_result: []
 
-codexia_review:
+codexia_review: []

src/test/resources/db-rider/bot/expected/noStarsUpResults_githubRepoWithOneStat.yml

@@ -1,3 +1,3 @@
-stars_up_result:
+stars_up_result: []
 
-codexia_review:
+codexia_review: []

src/test/resources/db-rider/bot/expected/noStarsUpResults_githubRepoWithThreeStats_happyPath.yml

@@ -13,5 +13,3 @@ codexia_review:
             (was: 402 stars, now: 473 stars).
             See the stars history
             [here](https://star-history.t9t.io/#test-project1/test-repo1).
-
-# @todo #6 here should be an assertion to `codexia_review_notification` table

src/test/resources/db-rider/bot/expected/noStarsUpResults_githubRepoWithThreeStats_starsIncreaseLessThan10.yml

@@ -1,3 +1,3 @@
-stars_up_result:
+stars_up_result: []
 
-codexia_review:
+codexia_review: []

src/test/resources/db-rider/bot/expected/noStarsUpResults_githubRepoWithThreeStats_starsIncreaseMoreThan10ButLessThan5Percents.yml

@@ -1,3 +1,3 @@
-stars_up_result:
+stars_up_result: []
 
-codexia_review:
+codexia_review: []

src/test/resources/db-rider/bot/expected/noStarsUpResults_githubRepoWithTwoStats_happyPath.yml

@@ -13,5 +13,3 @@ codexia_review:
             (was: 402 stars, now: 459 stars).
             See the stars history
             [here](https://star-history.t9t.io/#test-project1/test-repo1).
-
-# @todo #6 here should be an assertion to `codexia_review_notification` table

src/test/resources/db-rider/bot/expected/noStarsUpResults_githubRepoWithTwoStats_starsDecrease.yml

@@ -1,3 +1,3 @@
-stars_up_result:
+stars_up_result: []
 
-codexia_review:
+codexia_review: []

src/test/resources/db-rider/bot/expected/noStarsUpResults_githubRepoWithTwoStats_starsIncreaseLessThan10.yml

@@ -1,3 +1,3 @@
-stars_up_result:
+stars_up_result: []
 
-codexia_review:
+codexia_review: []

src/test/resources/db-rider/bot/expected/noStarsUpResults_githubRepoWithTwoStats_starsIncreaseMoreThan10ButLessThan5Percents.yml

@@ -1,3 +1,3 @@
-stars_up_result:
+stars_up_result: []
 
-codexia_review:
+codexia_review: []

src/test/resources/db-rider/bot/expected/noStarsUpResults_githubRepoWithTwoStats_withTwoEqualStars.yml

@@ -1,3 +1,3 @@
-stars_up_result:
+stars_up_result: []
 
-codexia_review:
+codexia_review: []

src/test/resources/db-rider/bot/expected/noStarsUpResults_githubRepoWithoutStat.yml

@@ -1,3 +1,3 @@
-stars_up_result:
+stars_up_result: []
 
-codexia_review:
+codexia_review: []

src/test/resources/db-rider/bot/expected/oneStarsUpResult_githubRepoWithFourStats_happyPath.yml

@@ -0,0 +1,18 @@
+stars_up_result:
+    -
+        github_repo_id: 1
+        github_repo_stat_id: 3
+    -
+        github_repo_id: 1
+        github_repo_stat_id: 5
+
+codexia_review:
+    -
+        codexia_project_id: 5
+        author: "STARS_UP"
+        reason: "528"
+        text: >-
+            The repo gained 69 stars since 2020-02-16T18:46:09.652645Z
+            (was: 459 stars, now: 528 stars).
+            See the stars history
+            [here](https://star-history.t9t.io/#test-project1/test-repo1).

src/test/resources/db-rider/bot/expected/oneStarsUpResult_githubRepoWithThreeStats_happyPath.yml

@@ -0,0 +1,18 @@
+stars_up_result:
+    -
+        github_repo_id: 1
+        github_repo_stat_id: 3
+    -
+        github_repo_id: 1
+        github_repo_stat_id: 4
+
+codexia_review:
+    -
+        codexia_project_id: 5
+        author: "STARS_UP"
+        reason: "502"
+        text: >-
+            The repo gained 43 stars since 2020-02-16T18:46:09.652645Z
+            (was: 459 stars, now: 502 stars).
+            See the stars history
+            [here](https://star-history.t9t.io/#test-project1/test-repo1).

src/test/resources/db-rider/bot/expected/oneStarsUpResult_noNewGithubStats.yml

@@ -0,0 +1,6 @@
+stars_up_result:
+    -
+        github_repo_id: 1
+        github_repo_stat_id: 3
+
+codexia_review: []

src/test/resources/db-rider/bot/expected/oneStarsUpResult_starsDecrease.yml

@@ -0,0 +1,6 @@
+stars_up_result:
+    -
+        github_repo_id: 1
+        github_repo_stat_id: 3
+
+codexia_review: []

src/test/resources/db-rider/bot/expected/oneStarsUpResult_starsIncreaseLessThan10.yml

@@ -0,0 +1,6 @@
+stars_up_result:
+    -
+        github_repo_id: 1
+        github_repo_stat_id: 3
+
+codexia_review: []

src/test/resources/db-rider/bot/expected/oneStarsUpResult_starsIncreaseMoreThan10ButLessThan5Percents.yml

@@ -0,0 +1,6 @@
+stars_up_result:
+    -
+        github_repo_id: 1
+        github_repo_stat_id: 3
+
+codexia_review: []

src/test/resources/db-rider/bot/initial/emptyDatabase.yml

@@ -1,5 +1,5 @@
-github_repo:
+github_repo: []
 
-github_repo_source:
+github_repo_source: []
 
-stars_up_result:
+stars_up_result: []

src/test/resources/db-rider/bot/initial/noStarsUpResults_githubRepoWithOneStat.yml

@@ -20,4 +20,4 @@ github_repo_stat:
         github_repo_id: 1
         type: "GITHUB_API"
 
-stars_up_result:
+stars_up_result: []

src/test/resources/db-rider/bot/initial/noStarsUpResults_githubRepoWithThreeStats_starsIncreaseLessThan10.yml

@@ -33,4 +33,4 @@ github_repo_stat:
         type: "GITHUB_API"
         stat: '{"type": "GITHUB_API", "stars": 132}'
 
-stars_up_result:
+stars_up_result: []

src/test/resources/db-rider/bot/initial/noStarsUpResults_githubRepoWithThreeStats_starsIncreaseMoreThan10ButLessThan5Percents.yml

@@ -33,4 +33,4 @@ github_repo_stat:
         type: "GITHUB_API"
         stat: '{"type": "GITHUB_API", "stars": 414}'
 
-stars_up_result:
+stars_up_result: []

src/test/resources/db-rider/bot/initial/noStarsUpResults_githubRepoWithTwoStats_starsDecrease.yml

@@ -27,4 +27,4 @@ github_repo_stat:
         type: "GITHUB_API"
         stat: '{"type": "GITHUB_API", "stars": 99}'
 
-stars_up_result:
+stars_up_result: []

src/test/resources/db-rider/bot/initial/noStarsUpResults_githubRepoWithTwoStats_starsIncreaseLessThan10.yml

@@ -27,4 +27,4 @@ github_repo_stat:
         type: "GITHUB_API"
         stat: '{"type": "GITHUB_API", "stars": 132}'
 
-stars_up_result:
+stars_up_result: []

src/test/resources/db-rider/bot/initial/noStarsUpResults_githubRepoWithTwoStats_starsIncreaseMoreThan10ButLessThan5Percents.yml

@@ -27,4 +27,4 @@ github_repo_stat:
         type: "GITHUB_API"
         stat: '{"type": "GITHUB_API", "stars": 414}'
 
-stars_up_result:
+stars_up_result: []

src/test/resources/db-rider/bot/initial/noStarsUpResults_githubRepoWithTwoStats_withTwoEqualStars.yml

@@ -27,4 +27,4 @@ github_repo_stat:
         type: "GITHUB_API"
         stat: '{"type": "GITHUB_API", "stars": 123}'
 
-stars_up_result:
+stars_up_result: []

src/test/resources/db-rider/bot/initial/noStarsUpResults_githubRepoWithoutStat.yml

@@ -13,6 +13,6 @@ github_repo_source:
         source: "CODEXIA"
         external_id: "12"
 
-github_repo_stat:
+github_repo_stat: []
 
-stars_up_result:
+stars_up_result: []

src/test/resources/db-rider/bot/initial/oneStarsUpResult_githubRepoWithFourStats_happyPath.yml

@@ -0,0 +1,63 @@
+github_repo:
+    -
+        id: 1
+        uuid: "groovy: UUID.randomUUID().toString()"
+        external_id: "150713223"
+        full_name: "test-project1/test-repo1"
+
+codexia_project:
+    -
+        id: 5
+        uuid: "groovy: UUID.randomUUID().toString()"
+        external_id: 12
+        coordinates: "test-project1/test-repo1"
+        author: "some-first-author"
+        author_id: 44
+        deleted: null
+        project_created_at: "2019-12-20 12:01:02"
+
+github_repo_source:
+    -
+        id: 1
+        uuid: "groovy: UUID.randomUUID().toString()"
+        github_repo_id: 1
+        source: "CODEXIA"
+        external_id: "12"
+
+github_repo_stat:
+    -
+        id: 1
+        uuid: "groovy: UUID.randomUUID().toString()"
+        github_repo_id: 1
+        type: "GITHUB_API"
+        stat: '{"type": "GITHUB_API", "stars": 402}'
+        created_at: "2020-02-11 10:06:16.123456"
+    -
+        id: 3
+        uuid: "groovy: UUID.randomUUID().toString()"
+        github_repo_id: 1
+        type: "GITHUB_API"
+        stat: '{"type": "GITHUB_API", "stars": 459}'
+        created_at: "2020-02-16 18:46:09.652645"
+    -
+        id: 4
+        uuid: "groovy: UUID.randomUUID().toString()"
+        github_repo_id: 1
+        type: "GITHUB_API"
+        stat: '{"type": "GITHUB_API", "stars": 502}'
+        created_at: "2020-02-21 07:12:34.333421"
+    -
+        id: 5
+        uuid: "groovy: UUID.randomUUID().toString()"
+        github_repo_id: 1
+        type: "GITHUB_API"
+        stat: '{"type": "GITHUB_API", "stars": 528}'
+        created_at: "2020-02-24 15:34:01.223344"
+
+stars_up_result:
+    -
+        uuid: "groovy: UUID.randomUUID().toString()"
+        github_repo_id: 1
+        github_repo_stat_id: 3
+
+codexia_review: []