Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodexiaModule.java:11-16: split... #19

Closed
0pdd opened this issue Apr 13, 2020 · 2 comments
Closed

CodexiaModule.java:11-16: split... #19

0pdd opened this issue Apr 13, 2020 · 2 comments

Comments

@0pdd
Copy link

0pdd commented Apr 13, 2020

The puzzle 6-02060b89 from #6 has to be resolved:

codexia-bot/src/main/java/dev/iakunin/codexiabot/codexia/CodexiaModule.java

Lines 11 to 16 in 12b0267

// @todo #6 split codexiaModule.sendReview() to codexiaModule.createReview() and codexiaModule.sendReview()
// - codexiaModule.createReview() - just a saving to DB.
// - codexiaModule.sendReview() - real sending review to Codexia api.
// - codexiaModule.sendReview() must be used ONLY inside a cron-job.
// - In other code there should be only a codexiaModule.createReview() calls.
// - All the codexiaModule.createReview() calls MUST be inside a transaction/

The puzzle was created by Maksim Iakunin on 13-Apr-20.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Apr 13, 2020
@iakunin
#6 - Implementing stars-up bot (#18)
12b0267 
* #6 - `Stars-up` bot: work in progress
* #6 - Changing puzzles format according to pdd
* #6 - Integration tests for StarsUp bot
* #6 - Another more integration tests for StarsUp bot
* #6 - StarsUp big methods decomposition
@0pdd 0pdd mentioned this issue Apr 13, 2020
Closed
iakunin added a commit that referenced this issue Apr 16, 2020
@iakunin
#19 - CodexiaModule: transforming sendReview to saveReview && ext…
42f1bc5 
…racting SendReviews cron
@iakunin iakunin mentioned this issue Apr 16, 2020
Merged
iakunin added a commit that referenced this issue Apr 16, 2020
@iakunin
#19 - Fixing CodeClimate violation
d3e293a
iakunin added a commit that referenced this issue Apr 16, 2020
@iakunin
#19 - Revert: Fixing CodeClimate violation
3477846
iakunin added a commit that referenced this issue Apr 17, 2020
@iakunin
#19 - Integration test for CodexiaReviewRepository.java::findAllWitho…
02f52c2 
…utNotifications()
iakunin added a commit that referenced this issue Apr 17, 2020
@iakunin
#19 - Integration test for SendReviews cron
f80fe0d
iakunin added a commit that referenced this issue Apr 17, 2020
@iakunin
#19 - Integration test for SendReviews cron
7e621ff
iakunin added a commit that referenced this issue Apr 17, 2020
@iakunin
#19 - Properly cleaning up db-rider state
61d65bf
iakunin added a commit that referenced this issue Apr 17, 2020
@iakunin
#19 - CodexiaModule: transforming sendReview to saveReview && ext…
c743679 
…racting SendReviews cron (#38)
@0pdd
Copy link
Author

0pdd commented Apr 17, 2020

The puzzle 6-02060b89 has disappeared from the source code, that's why I closed this issue.

@0pdd 0pdd closed this as completed Apr 17, 2020
This was referenced Apr 17, 2020
Open
Open
Open
@0pdd
Copy link
Author

0pdd commented Apr 17, 2020

@0pdd 3 puzzles #39, #40, #41 are still not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@0pdd