Merge pull request #57 from iambumblehead/add-vifm-warning-and-test

add vifm warning notice
iambumblehead · Mar 28, 2024 · 8d5363f · 8d5363f
2 parents e3dd5ac + 9190f4f
commit 8d5363f
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 # changelog
 
+ * 0.1.1 _Mar.28.2024_
+   * add [notice; vifm image preview not working](https://github.com/iambumblehead/thu.sh/pull/55)
+   * add [pdf test asset and pdf test](https://github.com/iambumblehead/thu.sh/pull/55)
  * 0.1.0 _Mar.27.2024_
    * remove [badgesize.io badge,](https://github.com/iambumblehead/thu.sh/pull/52) not working
    * use [integer timeout value](https://github.com/iambumblehead/thu.sh/pull/53) for darwin/mac read

diff --git a/README.md b/README.md
@@ -37,6 +37,9 @@ thu.sh /path/to/book.epub
 
 ----------------------------------------------
 
+> [!WARNING]
+> vifm image preview no longer working https://github.com/vifm/vifm/issues/731#issuecomment-2025267217
+
 **Add sixel image preview** to [vifm file manager.][10] Instructions [at the wiki.][11]
 
 <div align="left">

diff --git a/test/asset/test.pdf b/test/asset/test.pdf
diff --git a/test/test_unit.sh b/test/test_unit.sh
@@ -89,6 +89,17 @@ test_zip_move_file_out () {
     assert_matches "$containerurn" "$container"
 }
 
+test_thumb_create_from_pdf_magcick () {
+    pdfpath_inpdf="./asset/test.pdf"
+    pdfpath_outimg=$(thumb_create_from_pdf_magick "$pdfpath_inpdf" "400x400")
+
+    assert_matches "pdf.400x400.jpg$" "$pdfpath_outimg" \
+                   "should use naming pattern for generated file"
+    assert_matches "$([[ -f "$pdfpath_outimg" ]] && echo "true")" "true" \
+                   "should generate image file"
+}
+
+
 setup_suite() {
     source ../thu.sh
 }
diff --git a/thu.sh b/thu.sh
@@ -145,7 +145,7 @@ cache="true"
 timeoutssint=2 # must be integer for darwin/mac variant of 'read'
 sessbuild=""
 defaultw=10000
-version=0.1.0
+version=0.1.1
 while getopts "cer:bkl:jstivwz:h" opt; do
     case "${opt}" in
         c) cells="true";;