Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing literals + UserAgent __repr__ #15

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Conversation

novitae
Copy link
Contributor

@novitae novitae commented Oct 20, 2024

  • I added type hints for strings to display the possible string values when generating an user agent:
    Capture d’écran 2024-10-20 à 13 27 38
  • Also added a __repr__ method on the class to allow it to be displayed easily. We go from:
    Capture d’écran 2024-10-20 à 13 30 00
    To:
    Capture d’écran 2024-10-20 à 13 29 45

@iamdual
Copy link
Owner

iamdual commented Oct 20, 2024

Thanks. Merging.

@iamdual iamdual merged commit d8d05da into iamdual:master Oct 20, 2024
@iamdual
Copy link
Owner

iamdual commented Oct 20, 2024

I think some changes are not working for older versions. Can we do this in the next new releases or should we extend support directly to 3.9?

@iamdual
Copy link
Owner

iamdual commented Oct 20, 2024

Workflow tests are currently working for >=3.7. Also, README needs to be updated. Then the changes will be merged back.

@novitae
Copy link
Contributor Author

novitae commented Oct 20, 2024

Workflow tests are currently working for >=3.7. Also, README needs to be updated. Then the changes will be merged back.

Nice, what changes aren't supported in 3.6 exactly ?

@iamdual
Copy link
Owner

iamdual commented Oct 20, 2024

Workflow tests are currently working for >=3.7. Also, README needs to be updated. Then the changes will be merged back.

Nice, what changes aren't supported in 3.6 exactly ?

typing.Literal is not supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants